Diffusion FreeBSD src repository d2c65a1c9486

fflush: correct buffer handling in __sflush
d2c65a1c9486
Actions

Description

fflush: correct buffer handling in __sflush

Two additional stdio changes followed 86a16ada1ea6 and need to be
reverted as part of the fflush fix.

This reverts commit 6e13794fbe6e82c21365d0fd66769bf8b19c0197.
This reverts commit bafaa70b6f9098d83d074968c8e6747ecec1e118.

Fixes: d09a3bf72c0b ("fflush: correct buffer handling in __sflush")
Reviewed by: markj
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D42491

(cherry picked from commit 4e0e01bf6511c28212d7dff94fe131a502e13026)

Approved by: so

Details

Provenance

emaste

Authored on Nov 7 2023, 2:16 PM

Reviewer

markj

Differential Revision

D42491: fflush: correct buffer handling in __sflush

Parents

rGabe12d2f4ce3: libc: remove unused errno.h include

Branches

Unknown

Tags

Unknown

Reverts

rGbafaa70b6f90: libc __sfvwrite(): roll back FILE buffer pointer on fflush error
rG6e13794fbe6e: libc: Restore fp state upon flush error in fputc

Event Timeline

emaste committed rGd2c65a1c9486: fflush: correct buffer handling in __sflush (authored by emaste).Nov 7 2023, 5:31 PM

emaste added reverted changes: rG6e13794fbe6e: libc: Restore fp state upon flush error in fputc, rGbafaa70b6f90: libc __sfvwrite(): roll back FILE buffer pointer on fflush error.Nov 7 2023, 5:59 PM

emaste added an edge: D42491: fflush: correct buffer handling in __sflush.

emaste mentioned this in rG0b7939d725ba: fflush: correct buffer handling in __sflush.Nov 7 2023, 6:45 PM

emaste mentioned this in rG1f9c4610dde5: fflush: correct buffer handling in __sflush.Nov 8 2023, 12:46 AM

emaste mentioned this in rGd51a39b13ee4: fflush: correct buffer handling in __sflush.Nov 8 2023, 12:53 AM

Changes (2)

Path

Size

lib/

libc/

stdio/

fvwrite.c

wbuf.c

rGd2c65a1c9486

View Options

lib/libc/stdio/fvwrite.c