Paths

Table of Contentst

Differential D42360

arm64: Use the Linux sigframe to restore registers
ClosedPublic
Actions

Authored by andrew on Oct 25 2023, 10:35 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, May 16, 12:20 AM

	Unknown Object (File)
	Thu, May 9, 7:57 AM

	Unknown Object (File)
	Tue, May 7, 2:59 PM

	Unknown Object (File)
	Mon, May 6, 1:26 AM

	Unknown Object (File)
	Sun, Apr 28, 5:10 AM

	Unknown Object (File)
	Sat, Apr 27, 11:59 PM

	Unknown Object (File)
	Fri, Apr 26, 2:08 AM

	Unknown Object (File)
	Mon, Apr 22, 1:37 PM

View All 28 Files

Subscribers

Details

Reviewers

manu
dchagin
emaste

Group Reviewers

Commits

rG72b242ac15af: arm64: Use the Linux sigframe to restore registers
rGc21038f55230: arm64: Use the Linux sigframe to restore registers
rG070a4ff82a34: arm64: Use the Linux sigframe to restore registers

Summary

When returning from a Linux signal use the Linux sigframe to find the
register values to restore.

Remove the FreeBSD ucontext from the stack as it's now unneeded.

Sponsored by: Arm Ltd

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 54163
Build 51053: arc lint + arc unit

Event Timeline

andrew created this revision.Oct 25 2023, 10:35 AM

Herald added a reviewer: manu. · View Herald TranscriptOct 25 2023, 10:35 AM

Herald added subscribers: emaste, imp. · View Herald Transcript

andrew requested review of this revision.Oct 25 2023, 10:35 AM

Harbormaster completed remote builds in B54163: Diff 129376.Oct 25 2023, 10:35 AM

andrew added reviewers: arm64, dchagin.Oct 25 2023, 10:36 AM

Remove a change intended for a future review

Harbormaster completed remote builds in B54164: Diff 129377.Oct 25 2023, 10:37 AM

Nice, that was in my plans, I was waiting when SVE to be finished. Thanks!
So are the go tests suite passes now? I suspected that similarly to amd64 the problem is in the sigcontext layout on arm64.

sys/arm64/linux/linux_sysvec.c
220	there's gonna be a memory leak
224	Is it possible to out this code into a separate function?

I don't know about the go test suite. I've only tested with my tool to read the ID registers from userspace https://github.com/zxombie/arm64id/. This changes the pc the signal handler returns to and sets x0 to indicate the ID register is unable to be read from userspace.

sys/arm64/linux/linux_sysvec.c
220	Whoops, was added at the last minute & forgot to change the error path
224	We can. Linux also checks there is only one of each type.

Split out parsing the reserved array to a new function
Fix a memory leak

Harbormaster completed remote builds in B54165: Diff 129378.Oct 25 2023, 12:20 PM

Please add PR: 270250 to the commit message,
You have fixed this bug, golang tests suite passed. Thank you

This revision is now accepted and ready to land.Oct 25 2023, 4:50 PM

Macro shipit:

emaste accepted this revision.Oct 25 2023, 6:58 PM

Closed by commit rG070a4ff82a34: arm64: Use the Linux sigframe to restore registers (authored by andrew). · Explain WhyOct 27 2023, 9:43 AM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG070a4ff82a34: arm64: Use the Linux sigframe to restore registers.

dchagin added a commit: rGc21038f55230: arm64: Use the Linux sigframe to restore registers.Nov 6 2023, 3:13 PM

andrew added a commit: rG72b242ac15af: arm64: Use the Linux sigframe to restore registers.Feb 19 2024, 4:46 PM

Revision Contents
Changeset List

Path

Size

sys/

arm64/

linux/

linux_sigframe.h

1 line

94 lines

Diff 129376

sys/arm64/linux/linux_sigframe.h

Loading...

sys/arm64/linux/linux_sysvec.c

Loading...