Page MenuHomeFreeBSD
Differential D42230

arm64: Add a BTI landing pad to .mcount
ClosedPublic
Actions

Authored by andrew on Oct 16 2023, 4:08 PM.
Tags
None
Referenced Files
F83373989: D42230.id129164.diff
Thu, May 9, 3:48 PM
Unknown Object (File)
Thu, May 9, 4:29 AM
Unknown Object (File)
Sat, May 4, 10:47 AM
Unknown Object (File)
Wed, May 1, 8:49 AM
Unknown Object (File)
Mon, Apr 29, 4:58 AM
Unknown Object (File)
Sun, Apr 21, 5:42 PM
Unknown Object (File)
Sun, Apr 21, 2:06 PM
Unknown Object (File)
Sun, Apr 21, 8:26 AM
View All 18 Files
Subscribers
emaste
imp

Details

Reviewers
markj
manu
Group Reviewers
arm64
Commits
rGaace2b59a835: arm64: Add a BTI landing pad to .mcount
rGadb7f221a25e: arm64: Add a BTI landing pad to .mcount
rG0590ed0967e0: arm64: Add a BTI landing pad to .mcount
Summary

The .mcount function needs a BTI branch target. As we can't rely on
asm.h being included use the hint version of a "bti c" instruction.
This is a nop when BTI is not supported or not used.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew created this revision.Oct 16 2023, 4:08 PM
Herald added a reviewer: manu. · View Herald TranscriptOct 16 2023, 4:08 PM
Herald added subscribers: emaste, imp. · View Herald Transcript
andrew requested review of this revision.Oct 16 2023, 4:08 PM
andrew added a parent revision: D42229: rtld: Teach rtld about the BTI elf note.
Harbormaster completed remote builds in B54009: Diff 128840.Oct 16 2023, 4:08 PM
markj accepted this revision.Oct 17 2023, 2:03 PM
markj added inline comments.
sys/arm64/include/profile.h
71
This revision is now accepted and ready to land.Oct 17 2023, 2:03 PM
andrew updated this revision to Diff 129164.Oct 20 2023, 3:54 PM

Mention BTI_C

This revision now requires review to proceed.Oct 20 2023, 3:54 PM
Harbormaster completed remote builds in B54113: Diff 129164.Oct 20 2023, 3:54 PM
markj accepted this revision.Oct 23 2023, 2:05 PM
This revision is now accepted and ready to land.Oct 23 2023, 2:05 PM
Closed by commit rG0590ed0967e0: arm64: Add a BTI landing pad to .mcount (authored by andrew). · Explain WhyOct 30 2023, 5:56 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG0590ed0967e0: arm64: Add a BTI landing pad to .mcount.
andrew added a commit: rGadb7f221a25e: arm64: Add a BTI landing pad to .mcount.Feb 19 2024, 4:46 PM
andrew added a commit: rGaace2b59a835: arm64: Add a BTI landing pad to .mcount.

Revision Contents
Changeset List

PathSize
sys/
arm64/
include/
2 lines

Diff 129531

View Options

sys/arm64/include/profile.h

Loading...