Page MenuHomeFreeBSD
Differential D42020

freebsd-update: for rollback, first create directories
ClosedPublic
Actions

Authored by emaste on Sep 29 2023, 3:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 4, 1:16 PM
Unknown Object (File)
Tue, Apr 30, 8:23 PM
Unknown Object (File)
Fri, Apr 26, 1:52 AM
Unknown Object (File)
Thu, Apr 25, 11:19 PM
Unknown Object (File)
Thu, Apr 25, 11:19 PM
Unknown Object (File)
Thu, Apr 25, 2:31 PM
Unknown Object (File)
Thu, Apr 25, 8:44 AM
Unknown Object (File)
Sun, Apr 14, 5:33 PM
View All 18 Files
Subscribers
dim
imp
karels

Details

Reviewers
cperciva
khorben_defora.org
dim
Group Reviewers
releng
secteam
Commits
rG2b79df0ad999: freebsd-update: for rollback, first create directories
rGec5e6781b3a1: freebsd-update: for rollback, first create directories
rG6b27e1f2eaab: freebsd-update: for rollback, first create directories
Summary

rollback_files() tried to install files before creating the directories
for those files. In some cases this is due to special handling to
install certain classes of files earlier than others.

Just create all directories up front when performing rollback.

PR: 273950

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.Sep 29 2023, 3:34 PM
emaste created this revision.
emaste added a reviewer: khorben_defora.org.Oct 2 2023, 8:18 PM
karels added a subscriber: karels.Oct 17 2023, 2:56 AM

This one looks fairly straightforward; any thoughts on it?

karels mentioned this in D41945: freebsd-update: handle directories changing to files, too.Oct 17 2023, 4:29 PM
dim accepted this revision.Oct 17 2023, 5:17 PM
dim added a subscriber: dim.

It's a fairly big hammer, but it looks reasonable enough for me.

This revision is now accepted and ready to land.Oct 17 2023, 5:17 PM
Closed by commit rG6b27e1f2eaab: freebsd-update: for rollback, first create directories (authored by emaste). · Explain WhyOct 18 2023, 2:54 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rG6b27e1f2eaab: freebsd-update: for rollback, first create directories.
Herald added a subscriber: imp. · View Herald TranscriptOct 18 2023, 2:54 PM
emaste added a commit: rGec5e6781b3a1: freebsd-update: for rollback, first create directories.Jan 7 2024, 9:28 PM
emaste added a commit: rG2b79df0ad999: freebsd-update: for rollback, first create directories.Jan 8 2024, 2:46 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
freebsd-update/
5 lines

Diff 129011

View Options

usr.sbin/freebsd-update/freebsd-update.sh

Loading...