Paths

Table of Contentst

Differential D42018

arm64: Raise a SIGBUS on a user external abort
ClosedPublic
Actions

Authored by andrew on Sep 29 2023, 1:59 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jun 9, 9:35 AM

	Unknown Object (File)
	Fri, Jun 5, 11:06 PM

	Unknown Object (File)
	Sun, May 31, 8:54 PM

	Unknown Object (File)
	Sun, May 31, 2:20 PM

	Unknown Object (File)
	Sun, May 31, 2:02 PM

	Unknown Object (File)
	Thu, May 28, 8:29 PM

	Unknown Object (File)
	Mon, May 18, 8:32 AM

	Unknown Object (File)
	Sat, May 16, 12:27 AM

Subscribers

Details

Reviewers

markj
kib
manu

Group Reviewers

Commits

rG890008575a43: arm64: Raise a SIGBUS on a user external abort
rGf323ecb4e075: arm64: Raise a SIGBUS on a user external abort
rGa69450102ff1: arm64: Raise a SIGBUS on a user external abort

Summary

When userspace triggers an external abort allow it to handle the abort
by raising a SIGBUS.

Sponsored by: Arm Ltd

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Sep 29 2023, 1:59 PM

Herald added a reviewer: manu. · View Herald TranscriptSep 29 2023, 1:59 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

andrew requested review of this revision.Sep 29 2023, 1:59 PM

Harbormaster completed remote builds in B53764: Diff 128000.Sep 29 2023, 1:59 PM

markj added inline comments.Sep 29 2023, 2:19 PM

sys/arm64/arm64/trap.c
230	Does this mean that userspace can't reliably distinguish between a SIGBUS due to a vm_fault() failure and a SIGBUS due to an external abort?
239	No need to test `!lower` now.
246	Same here.

Remove unneeded lower checks

Harbormaster completed remote builds in B53766: Diff 128003.Sep 29 2023, 3:40 PM

kib added inline comments.Sep 29 2023, 5:03 PM

sys/arm64/arm64/trap.c
230	The app gets the fault address from FAR, which should be enough for it to understand the specific mapping that caused the trap. In other words, I think that there is no need for additional arch-specific BUS_XXX code for this situation.

Ping?

kib accepted this revision.Oct 11 2023, 5:38 PM

This revision is now accepted and ready to land.Oct 11 2023, 5:38 PM

markj accepted this revision.Oct 11 2023, 7:56 PM

Closed by commit rGa69450102ff1: arm64: Raise a SIGBUS on a user external abort (authored by andrew). · Explain WhyOct 16 2023, 10:48 AM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rGa69450102ff1: arm64: Raise a SIGBUS on a user external abort.

andrew added a commit: rGf323ecb4e075: arm64: Raise a SIGBUS on a user external abort.Feb 19 2024, 4:46 PM

andrew added a commit: rG890008575a43: arm64: Raise a SIGBUS on a user external abort.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

arm64/

10 lines

Diff 128819

sys/arm64/arm64/trap.c

Loading...