Page MenuHomeFreeBSD
Differential D41550

smartpqi: update to version 4410.0.2005
ClosedPublic
Actions

Authored by john.hall_microchip.com on Aug 22 2023, 3:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 6:53 AM
Unknown Object (File)
Tue, Apr 16, 12:43 AM
Unknown Object (File)
Thu, Apr 11, 4:28 PM
Unknown Object (File)
Wed, Apr 10, 12:28 AM
Unknown Object (File)
Tue, Apr 9, 5:04 PM
Unknown Object (File)
Mon, Apr 8, 8:02 AM
Unknown Object (File)
Mon, Apr 8, 2:25 AM
Unknown Object (File)
Tue, Apr 2, 3:52 AM
View All 23 Files
Subscribers
imp

Details

Reviewers
scott.benesh_microsemi.com
imp
Commits
rG7ea28254ec53: smartpqi: update to version 4410.0.2005
Summary

This updates the source of the smartpqi driver to the latest release 4410.0.2005.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

john.hall_microchip.com requested review of this revision.Aug 22 2023, 3:16 PM
john.hall_microchip.com created this revision.
john.hall_microchip.com created this object with visibility "Custom Policy".
john.hall_microchip.com created this object with edit policy "Custom Policy".
john.hall_microchip.com added a reviewer: imp.
john.hall_microchip.com changed the visibility from "Custom Policy" to "Custom Policy".
john.hall_microchip.com changed the edit policy from "Custom Policy" to "Custom Policy".
imp added a comment.Aug 22 2023, 5:55 PM

So this generally looks good. Left a couple of comments
But since this is mostly managed by microchip, maybe it should be in sys/contrib/dev/smartpqi to indicate that? Thoughts?
I can't really commment on the bulk of these changes, since they are very dependent on the hardware that I'm unfamiliar with.

share/man/man4/smartpqi.4
29

We just removed all $FreeBSD$ from the tree... Here and below...

sys/modules/smartpqi/Makefile
6

this likely won't work in the FreeBSD tree.

8

We've been trying to do these as one per line...

john.hall_microchip.com updated this revision to Diff 126384.Aug 22 2023, 6:11 PM
john.hall_microchip.com marked an inline comment as done.
john.hall_microchip.com updated this revision to Diff 126386.Aug 22 2023, 6:29 PM
john.hall_microchip.com marked 2 inline comments as done.
john.hall_microchip.com updated this revision to Diff 126387.Aug 22 2023, 6:32 PM

Removed extra line I added

scott.benesh_microsemi.com added a comment.Aug 22 2023, 6:44 PM

Not sure what sys/contrib/dev would buy us. We would want the driver in the kernel so doesn't it have to be in sys/dev ?

imp added a comment.Aug 22 2023, 7:35 PM
In D41550#946911, @scott.benesh_microsemi.com wrote:

Not sure what sys/contrib/dev would buy us. We would want the driver in the kernel so doesn't it have to be in sys/dev ?

sys/contrib/dev buys two things (and doesn't do one thing you think)

  1. It turns off a number of formatting and pedantic requirements for formatting. This will become increasingly more important as time rolls on and the FreeBSD project tries to get more in line with other projects.
  2. You can use a 'vendor tree' to merge in your vendor changes. This lets you more easily manage the diffs that FreeBSD has added to keep the driver up to date with the latest APIs between imports from the vendor.

It does not mean it won't be in the GENERIC kernel. That's controlled via a different mechanism.

It's also just a suggestion based on microchip's recent publication of its latest linux driver on github.

scott.benesh_microsemi.com added a comment.Aug 24 2023, 3:47 PM
In D41550#946927, @imp wrote:
In D41550#946911, @scott.benesh_microsemi.com wrote:

Not sure what sys/contrib/dev would buy us. We would want the driver in the kernel so doesn't it have to be in sys/dev ?

sys/contrib/dev buys two things (and doesn't do one thing you think)

  1. It turns off a number of formatting and pedantic requirements for formatting. This will become increasingly more important as time rolls on and the FreeBSD project tries to get more in line with other projects.
  2. You can use a 'vendor tree' to merge in your vendor changes. This lets you more easily manage the diffs that FreeBSD has added to keep the driver up to date with the latest APIs between imports from the vendor.

It does not mean it won't be in the GENERIC kernel. That's controlled via a different mechanism.

It's also just a suggestion based on microchip's recent publication of its latest linux driver on github.

Sounds interesting. We will keep this in mind for future projects. As for now let's just keep it in sys/dev .

Are we in time to get this added? Any one else we should have look this over?

imp added a comment.Aug 24 2023, 8:18 PM

OK. I'll commit this, assuming it builds. that should make it under the wire for 14.0. And I'll not plan on MFCing this, per earlier discussions.

Look forward to future moves of the driver, but agree it might be a smidge late to do that now.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 24 2023, 9:30 PM
Closed by commit rG7ea28254ec53: smartpqi: update to version 4410.0.2005 (authored by john.hall_microchip.com, committed by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG7ea28254ec53: smartpqi: update to version 4410.0.2005.
john.hall_microchip.com changed the visibility from "Custom Policy" to "Public (No Login Required)".Aug 29 2023, 4:38 PM

Revision Contents
Changeset List

PathSize
share/
man/
man4/
59 lines
sys/
conf/
1 line
dev/
smartpqi/
294 lines
14 lines
523 lines
1246 lines
83 lines
520 lines
smartpqi_helper.h
smartpqi_cmd.c
76 lines
180 lines
7 lines
541 lines
31 lines
4 lines
61 lines
307 lines
10 lines
140 lines
185 lines
521 lines
2204 lines
248 lines
34 lines
591 lines
36 lines
modules/
smartpqi/
2 lines

Diff 126502

View Options

share/man/man4/smartpqi.4

Loading...
View Options

sys/conf/files.amd64

Loading...
View Options

sys/dev/smartpqi/smartpqi_cam.c

Loading...
View Options

sys/dev/smartpqi/smartpqi_cmd.c

Loading...
View Options

sys/dev/smartpqi/smartpqi_defines.h

Loading...
View Options

sys/dev/smartpqi/smartpqi_discovery.c

Loading...
View Options

sys/dev/smartpqi/smartpqi_event.c

Loading...
View Options

sys/dev/smartpqi/smartpqi_features.c

Loading...
View Options

sys/dev/smartpqi/smartpqi_helper.h

Loading...
View Options

sys/dev/smartpqi/smartpqi_helper.c

Loading...
View Options

sys/dev/smartpqi/smartpqi_includes.h

Loading...
View Options

sys/dev/smartpqi/smartpqi_init.c

Loading...
View Options

sys/dev/smartpqi/smartpqi_intr.c

Loading...
View Options

sys/dev/smartpqi/smartpqi_ioctl.h

Loading...
View Options

sys/dev/smartpqi/smartpqi_ioctl.c

Loading...
View Options

sys/dev/smartpqi/smartpqi_main.c

Loading...
View Options

sys/dev/smartpqi/smartpqi_mem.c

Loading...
View Options

sys/dev/smartpqi/smartpqi_misc.c

Loading...
View Options

sys/dev/smartpqi/smartpqi_prototypes.h

Loading...
View Options

sys/dev/smartpqi/smartpqi_queue.c

Loading...
View Options

sys/dev/smartpqi/smartpqi_request.c

Loading...
View Options

sys/dev/smartpqi/smartpqi_response.c

Loading...
View Options

sys/dev/smartpqi/smartpqi_sis.c

Loading...
View Options

sys/dev/smartpqi/smartpqi_structures.h

Loading...
View Options

sys/dev/smartpqi/smartpqi_tag.c

Loading...
View Options

sys/modules/smartpqi/Makefile

Loading...