Page MenuHomeFreeBSD

Makefile: Support universe-toolchain on non-FreeBSD
ClosedPublic

Authored by jrtc27 on Aug 22 2023, 3:00 AM.
Tags
None
Referenced Files
F87061505: D41545.id126353.diff
Fri, Jun 28, 8:23 PM
Unknown Object (File)
May 21 2024, 8:30 PM
Unknown Object (File)
Apr 30 2024, 9:42 PM
Unknown Object (File)
Apr 20 2024, 5:34 PM
Unknown Object (File)
Mar 18 2024, 2:03 PM
Unknown Object (File)
Mar 7 2024, 11:36 AM
Unknown Object (File)
Mar 7 2024, 11:36 AM
Unknown Object (File)
Mar 7 2024, 11:36 AM
Subscribers
None

Details

Summary

We currently pass MACHINE and MACHINE_ARCH as TARGET and TARGET_ARCH
respectively for universe-toolchain, but on non-FreeBSD these may not
have values that we understand (e.g. on Linux it will be x86_64 rather
than amd64) for TARGET/TARGET_ARCH (note that we do support them for
MACHINE/MACHINE_ARCH). Since the choice is a bit arbitrary and merely
determines what LLVM's default triple will be, use amd64 on non-FreeBSD
as a known-good default.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 53227
Build 50118: arc lint + arc unit

Event Timeline

jrtc27 created this revision.

This just chooses the default -target in effect?

This revision is now accepted and ready to land.Aug 23 2023, 4:34 PM
In D41545#947168, @jhb wrote:

This just chooses the default -target in effect?

I believe that's all this affects, yes