i386: move to EXTRA_TARGETS
Needs ReviewPublic
Actions

Authored by obrien on Wed, Nov 12, 6:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 15, 2:54 AM

	Unknown Object (File)
	Sat, Nov 15, 2:51 AM

	Unknown Object (File)
	Sat, Nov 15, 2:51 AM

	Unknown Object (File)
	Sat, Nov 15, 2:44 AM

	Unknown Object (File)
	Fri, Nov 14, 5:20 AM

	Unknown Object (File)
	Fri, Nov 14, 5:20 AM

	Unknown Object (File)
	Fri, Nov 14, 5:19 AM

	Unknown Object (File)
	Fri, Nov 14, 2:36 AM

Subscribers

This revision needs review, but there are no reviewers specified.

Details

Reviewers: None

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 68577
Build 65460: arc lint + arc unit

Event Timeline

obrien created this revision.Wed, Nov 12, 6:16 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Nov 12, 6:16 PM

obrien requested review of this revision.Wed, Nov 12, 6:16 PM

Harbormaster completed remote builds in B68576: Diff 166311.Wed, Nov 12, 6:16 PM

missed a 'git add'

Herald added subscribers: emaste, bdrewery. · View Herald TranscriptWed, Nov 12, 6:22 PM

Harbormaster completed remote builds in B68577: Diff 166313.Wed, Nov 12, 6:22 PM

The issue with MAKE_LINT_KERNELS is that it doesn't ignore NO_UNIVERSE kernels which perhaps it should do. OTOH, MAKE_ALL_KERNELS also doesn't ignore NO_UNIVERSE by design. Maybe we need a NO_UNIVERSE_I_MEAN_IT_FOR_REALS or we just filter out i386 from MAKE_LINT_KERNELS and MAKE_ALL_KERNELS. I never use MAKE_LINT_KERNELS myself as they really aren't that much more to build.

Makefile
540	I think this is a no-op. TARGET_MACHINE_LIST already includes i386.

We do want i386 worlds building by default though in make universe, and we need a manual make buildworld TARGET_ARCH=i386 to still work, and this breaks both of those (I tried it previously).