Implement atomic_testandset() for arm v6.
ClosedPublic
Actions

Authored by kib on Nov 9 2015, 8:21 AM.

Details

Reviewers

andrew
mmel
skra
• ian

Commits

rS290649: Implement atomic_testandset_{32,int,long,64} for ARMv6. Only

Summary

I am not sure is it reasonable to have BIG_ENDIAN case for ARMv6, do we ever run or plan to run in the big endian mode ?

I have no intention to handle ARMv4 right now, unless somebody objects to implementing only ARMv6 support.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib updated this revision to Diff 10053.Nov 9 2015, 8:21 AM

kib retitled this revision from to Implement atomic_testandset() for arm v6..

kib updated this object.

kib edited the test plan for this revision. (Show Details)

kib added reviewers: • ian, andrew, skra, mmel.

kib set the repository for this revision to rS FreeBSD src repository - subversion.

kib added a project: ARM.

Herald added a subscriber: imp. · View Herald TranscriptNov 9 2015, 8:21 AM

I thing that we don't support BE for ARMv6+.

mmel added inline comments.Nov 9 2015, 2:38 PM

sys/arm/include/atomic-v6.h
610 ↗	(On Diff #10053)	'p' is pointer and its not changed within asm block. Why is listed as output (read/write) argument?

Specify the pointer as the input argument, relying on the memory clobber for the side-effects.
Remove big-endian case.

mmel accepted this revision.Nov 10 2015, 9:55 AM

mmel edited edge metadata.

This revision is now accepted and ready to land.Nov 10 2015, 9:55 AM

Closed by commit rS290649: Implement atomic_testandset_{32,int,long,64} for ARMv6. Only (authored by kib). · Explain WhyNov 10 2015, 12:15 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

arm/

include/

atomic-v6.h

48 lines

Diff 10090

View Options

head/sys/arm/include/atomic-v6.h

Implement atomic_testandset() for arm v6.ClosedPublicActions