Details

share/man/man4/dtrace_kinst.4
2–5	Sorry for not catching this during the original review. We avoid adding "All rights reserved" to new copyright notices - would you be willing to remove this one, since you're the only copyright holder?
53	There are many tools that can disassemble machine code, so I'd even not mention gdb specifically. It's enough to say that <instruction> is the offset of the instruction relative to the beginning of the function.
57
72	It's best to use the lower case names, since those are the names used internally by FreeBSD (reported by uname and so on). You could add a link to arch(7) in the SEE ALSO section.
186
192

Address Mark's comments.

Harbormaster completed remote builds in B52430: Diff 124167.Jul 4 2023, 2:31 PM

Forgot to link arch(7).

Harbormaster completed remote builds in B52431: Diff 124168.Jul 4 2023, 2:33 PM

s/vm_page_mvqueue/critical_enter/

Harbormaster completed remote builds in B52484: Diff 124299.Jul 7 2023, 5:44 PM

christos edited the summary of this revision. (Show Details)Jul 11 2023, 1:18 PM

Remove BUGS section since per-probe trampolines seem to have fixed it.

Harbormaster completed remote builds in B52560: Diff 124492.Jul 11 2023, 1:20 PM

Mention unsafe-to-trace functions and instructions, as well as ADR/ADRP bug in
arm64.

Harbormaster completed remote builds in B52576: Diff 124539.Jul 12 2023, 1:23 PM

markj added inline comments.Jul 13 2023, 5:54 PM

share/man/man4/dtrace_kinst.4
192	We can be more precise now: the problem is a micro-optimization in the arm64 exception handler which breaks emulation of adr/adrp.

Explain why ADR and ADRP are disabled.

Harbormaster completed remote builds in B52635: Diff 124641.Jul 13 2023, 10:07 PM

yuripv added a subscriber: yuripv.Jul 17 2023, 2:38 PM

yuripv added inline comments.

share/man/man4/dtrace_kinst.4

The way this is done defeats the -column usage. How about the following instead (same for other table below)?

.Bl -column "cpu_exception_handler_supervisor"
.It Sy Function Ta Sy Architecture
.It cpu_switch Ta all
.It db_* Ta all
.It dtrace_* Ta all
.It kdb_* Ta all
.It kinst_* Ta all
.It owner_mtx Ta all
.It owner_rm Ta all
.It owner_rw Ta all
.It owner_sx Ta all
.It trap_check Ta all
.It do_el0_sync Ta arm64
.It do_el1h_sync Ta arm64
.It handle_el0_sync Ta arm64
.It handle_el1h_sync Ta arm64
.It cpu_exception_handler Ta riscv
.It cpu_exception_handler_supervisor Ta riscv
.It cpu_exception_handler_user Ta riscv
.It do_trap_supervisor Ta riscv
.It do_trap_user Ta riscv
.El