Page MenuHomeFreeBSD

arm64: Fix a use of update_lower_register
ClosedPublic

Authored by andrew on Jul 3 2023, 11:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 1, 7:02 AM
Unknown Object (File)
Tue, Apr 30, 11:56 AM
Unknown Object (File)
Tue, Apr 30, 12:07 AM
Unknown Object (File)
Mon, Apr 22, 7:43 PM
Unknown Object (File)
Apr 6 2024, 1:08 PM
Unknown Object (File)
Jan 5 2024, 10:30 PM
Unknown Object (File)
Dec 25 2023, 5:16 PM
Unknown Object (File)
Dec 23 2023, 1:48 AM

Details

Summary

In get_kernel_reg_masked we use update_lower_register to get the lower
value of two registers for a given field. It will return the entire
register value with just the single field updated.

Because of this get_kernel_reg_masked needs to use the returned value
directly rather than ORing each field together. Fix this by updating
the mask and returning that from get_kernel_reg_masked.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jul 4 2023, 2:38 PM
christos added inline comments.
sys/arm64/arm64/identcpu.c
1829

Did you mean valp instead?

This revision was automatically updated to reflect the committed changes.