rtld: Clear x29 for thread_start to conform Aarch64 ABI ps
ClosedPublic
Actions

Also clear lr,
strictly speaking, SYS V Aarch64 ABI does not states that lr should be
cleared, however gdb relies on it value and tryes to unwind stack further.

Harbormaster completed remote builds in B52388: Diff 124107.Jul 2 2023, 8:19 PM

dchagin mentioned this in D40620: libthr: Add an annotated _thread_start to satisfy unwinders on x86 and arm64.Jul 3 2023, 9:36 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 7 2023, 4:56 PM

Closed by commit rG1a2aa2ffb502: rtld: Clear x29 and lr for thread_start to conform Aarch64 ABI pcs (authored by dchagin). · Explain Why

This revision was automatically updated to reflect the committed changes.

dchagin added a commit: rG1a2aa2ffb502: rtld: Clear x29 and lr for thread_start to conform Aarch64 ABI pcs.

arichardson mentioned this in D46400: [RISC-V] Set ra to zero when calling into userspace.Aug 21 2024, 5:29 PM

Revision Contents
Changeset List

Path

Size

sys/

arm64/

vm_machdep.c

2 lines

Diff 124296

View Options

sys/arm64/arm64/vm_machdep.c

rtld: Clear x29 for thread_start to conform Aarch64 ABI psClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 124296

sys/arm64/arm64/vm_machdep.c

rtld: Clear x29 for thread_start to conform Aarch64 ABI ps
ClosedPublic
Actions

Revision Contents
Changeset List