Page MenuHomeFreeBSD

dtrace: improve siftr probe
ClosedPublic

Authored by tuexen on Jul 1 2023, 9:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 3, 5:23 PM
Unknown Object (File)
Thu, Oct 3, 2:16 PM
Unknown Object (File)
Mon, Sep 30, 9:37 PM
Unknown Object (File)
Sun, Sep 29, 1:27 AM
Unknown Object (File)
Sat, Sep 28, 11:08 AM
Unknown Object (File)
Wed, Sep 25, 2:03 PM
Unknown Object (File)
Tue, Sep 24, 4:51 PM
Unknown Object (File)
Mon, Sep 23, 4:35 PM

Details

Summary

Improve consistency of the field names with tcpsinfo_t:

  • Use mss instead of max_seg_size.
  • Use lport and rport instead of tcp_localport and tcp_foreignport.

Use t_flags instead of flags to improve consistency with t_flags2.

Add laddr and raddr, since the addresses were missing when compared to the output of siftr.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tuexen requested review of this revision.Jul 1 2023, 9:38 PM
cc requested changes to this revision.Jul 1 2023, 9:56 PM
cc added inline comments.
sys/netinet/siftr.c
228–230

Looks we can safely remove these three and use your newly added ones to print (snprintf).

This revision now requires changes to proceed.Jul 1 2023, 9:56 PM

Remove the ipver field of struct flowinfo, since it was never read.

tuexen added inline comments.
sys/netinet/siftr.c
228–230

It is save to remove ipver, since it was never read.
lport and rport are read when writing the flow summary at which point we don't have a struct pkt_node. So they are needed in struct flow_info.
So I guess we have to live with the duplication...

This revision is now accepted and ready to land.Jul 2 2023, 11:53 AM
This revision was automatically updated to reflect the committed changes.
tuexen marked an inline comment as done.