Hide irq_next_free, it's not used out of this file
ClosedPublic
Actions

Authored by andrew on Jun 27 2023, 8:37 AM.

Details

Reviewers

Group Reviewers

arm64
ARM
riscv

Commits

rG1e0ba9d43cf0: Hide irq_next_free, it's not used out of this file

Summary

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Jun 27 2023, 8:37 AM

Herald added a subscriber: imp. · View Herald TranscriptJun 27 2023, 8:37 AM

andrew requested review of this revision.Jun 27 2023, 8:37 AM

Harbormaster completed remote builds in B52294: Diff 123813.Jun 27 2023, 8:37 AM

andrew added a child revision: D40768: Continue searching for an irq map from the start.Jun 27 2023, 8:37 AM

It has no external declaration I suppose?

This revision is now accepted and ready to land.Jun 27 2023, 5:13 PM

I only see it in subr_intr.c:

% git grep irq_next_free
sys/kern/subr_intr.c:static u_int irq_next_free;
sys/kern/subr_intr.c:   if (irq_next_free >= intr_nirq)
sys/kern/subr_intr.c:   for (irq = irq_next_free; irq < intr_nirq; irq++) {
sys/kern/subr_intr.c:   for (irq = 0; irq < irq_next_free; irq++) {
sys/kern/subr_intr.c:   irq_next_free = intr_nirq;
sys/kern/subr_intr.c:   irq_next_free = irq + 1;
sys/kern/subr_intr.c:   if (irq_next_free >= intr_nirq)
sys/kern/subr_intr.c:           irq_next_free = 0;
sys/kern/subr_intr.c:   if (irq_next_free >= intr_nirq)
sys/kern/subr_intr.c:           irq_next_free = 0;

Closed by commit rG1e0ba9d43cf0: Hide irq_next_free, it's not used out of this file (authored by andrew). · Explain WhyJun 28 2023, 5:03 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG1e0ba9d43cf0: Hide irq_next_free, it's not used out of this file.