dtrace/arm64: Fix PAN handling in some dtrace operations
ClosedPublic
Actions

Authored by markj on Jun 14 2023, 2:47 PM.

Details

Reviewers

gnn
andrew

Group Reviewers

DTrace
arm64

Commits

rG7d86d8ed848e: dtrace/arm64: Fix user memory access routines
rG6281147a963b: dtrace/arm64: Fix user memory access routines

Summary

Without this, various dtrace actions such as ustack() simply fail.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jun 14 2023, 2:47 PM

Herald added a reviewer: gnn. · View Herald TranscriptJun 14 2023, 2:47 PM

Herald added subscribers: emaste, andrew, imp. · View Herald Transcript

markj requested review of this revision.Jun 14 2023, 2:47 PM

Harbormaster completed remote builds in B52050: Diff 123206.Jun 14 2023, 2:47 PM

markj added a parent revision: D40539: dtrace/arm64: Store the fault address when suppressing a page fault.Jun 14 2023, 2:47 PM

Could uou use the ldtr* instructions here? They perform a load as if it was the user so there would be no need to disable PAN.

Use ldtr* instead of disabling PAN.

Harbormaster completed remote builds in B52051: Diff 123207.Jun 14 2023, 3:07 PM

andrew accepted this revision.Jun 14 2023, 3:08 PM

This revision is now accepted and ready to land.Jun 14 2023, 3:08 PM

Closed by commit rG6281147a963b: dtrace/arm64: Fix user memory access routines (authored by markj). · Explain WhyJun 15 2023, 4:41 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG6281147a963b: dtrace/arm64: Fix user memory access routines.

markj added a commit: rG7d86d8ed848e: dtrace/arm64: Fix user memory access routines.Jun 23 2023, 1:54 PM

Revision Contents
Changeset List

Path

Size

sys/

cddl/

dev/

dtrace/

aarch64/

dtrace_asm.S

16 lines

Diff 123290

View Options

sys/cddl/dev/dtrace/aarch64/dtrace_asm.S

dtrace/arm64: Fix PAN handling in some dtrace operationsClosedPublicActions