Page MenuHomeFreeBSD
Differential D40302

siftr: three changes that improve performance
ClosedPublic
Actions

Authored by cc on May 27 2023, 1:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 14, 4:58 AM
Unknown Object (File)
Mar 30 2024, 9:33 AM
Unknown Object (File)
Mar 15 2024, 1:12 AM
Unknown Object (File)
Mar 9 2024, 9:36 PM
Unknown Object (File)
Dec 23 2023, 4:23 AM
Unknown Object (File)
Dec 22 2023, 7:29 PM
Unknown Object (File)
Dec 12 2023, 8:19 AM
Unknown Object (File)
Dec 9 2023, 10:43 PM
View All 54 Files
Subscribers
glebius
imp
melifaro

Details

Reviewers
rscheff
tuexen
Commits
rGaa61cff4249c: siftr: three changes that improve performance
Summary

(1) use inp_flowid or a new packet hash for a flow identification
(2) cache constant connection info into struct flow_hash_node
(3) use compressed notation for IPv6 address representation

Test Plan

test result: test result of D40302
This patch brings about +6% ~ +8% better performance for the IPv4 traffic and about +12% ~ +17% better performance for the IPv6 traffic.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 51755
Build 48646: arc lint + arc unit

Event Timeline

cc created this revision.May 27 2023, 1:06 PM
Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptMay 27 2023, 1:06 PM
cc requested review of this revision.May 27 2023, 1:06 PM
Harbormaster completed remote builds in B51735: Diff 122514.May 27 2023, 1:06 PM
cc edited the test plan for this revision. (Show Details)May 27 2023, 1:12 PM
cc edited the test plan for this revision. (Show Details)May 28 2023, 11:56 PM
tuexen added inline comments.May 29 2023, 8:53 AM
share/man/man4/siftr.4
86
  1. Please add a space between ) and f.
  2. The format change of the IPv6 addresses is not mentioned in the commit message.
tuexen added inline comments.May 29 2023, 9:35 AM
share/man/man4/siftr.4
86

I forgot: I think you can also remove the last entry in the BUGS section

cc updated this revision to Diff 122560.May 29 2023, 10:32 AM

update based on comments

Harbormaster completed remote builds in B51755: Diff 122560.May 29 2023, 10:32 AM
cc retitled this revision from siftr: two changes that improve performance to siftr: three changes that improve performance.May 29 2023, 10:33 AM
cc edited the summary of this revision. (Show Details)
cc edited the test plan for this revision. (Show Details)May 29 2023, 11:14 AM
tuexen accepted this revision.May 29 2023, 12:43 PM
This revision is now accepted and ready to land.May 29 2023, 12:43 PM
cc marked 2 inline comments as done.May 29 2023, 1:09 PM

Thank you Michael for this review!

Closed by commit rGaa61cff4249c: siftr: three changes that improve performance (authored by cc). · Explain WhyMay 29 2023, 1:13 PM
This revision was automatically updated to reflect the committed changes.
cc added a commit: rGaa61cff4249c: siftr: three changes that improve performance.

Revision Contents
Changeset List

PathSize
share/
man/
man4/
10 lines
sys/
netinet/
533 lines

Diff 122560

View Options

share/man/man4/siftr.4

Loading...
View Options

sys/netinet/siftr.c

Loading...