Print registers on an arm64 spinlock data abort
ClosedPublic
Actions

Authored by andrew on May 23 2023, 9:30 AM.

Details

Reviewers

kib
manu

Group Reviewers

arm64

Commits

rGed2d2423470d: Print registers on an arm64 spinlock data abort
rG0731b0a9f1f9: Print registers on an arm64 spinlock data abort

Summary

When checking if the spinlock count is correct in a data abort we can
panic without printing the registers. These are useful to debug the
abort, e.g. by giving the fault address register.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.May 23 2023, 9:30 AM

Herald added a reviewer: manu. · View Herald TranscriptMay 23 2023, 9:30 AM

Herald added subscribers: emaste, imp. · View Herald Transcript

andrew requested review of this revision.May 23 2023, 9:30 AM

Harbormaster completed remote builds in B51631: Diff 122273.May 23 2023, 9:30 AM

kib accepted this revision.May 23 2023, 9:37 AM

kib added inline comments.

sys/arm64/arm64/trap.c
332	print the spinlock nest counter as well, perhaps?

This revision is now accepted and ready to land.May 23 2023, 9:37 AM

Closed by commit rG0731b0a9f1f9: Print registers on an arm64 spinlock data abort (authored by andrew). · Explain WhyMay 24 2023, 4:20 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG0731b0a9f1f9: Print registers on an arm64 spinlock data abort.

andrew added a commit: rGed2d2423470d: Print registers on an arm64 spinlock data abort.Sep 25 2023, 11:03 AM

Revision Contents
Changeset List

Path

Size

sys/

arm64/

trap.c

10 lines

Diff 122379

View Options

Print registers on an arm64 spinlock data abortClosedPublicActions