Differential D4019

Use lladdr_event to propagate gratiotus arp.
ClosedPublic
Actions

Authored by melifaro on Oct 27 2015, 8:55 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 28, 5:48 PM

	Unknown Object (File)
	Thu, Nov 28, 5:48 PM

	Unknown Object (File)
	Tue, Nov 26, 10:07 PM

	Unknown Object (File)
	Sun, Nov 24, 9:53 AM

	Unknown Object (File)
	Nov 5 2024, 8:52 AM

	Unknown Object (File)
	Oct 24 2024, 9:51 PM

	Unknown Object (File)
	Oct 12 2024, 10:40 PM

	Unknown Object (File)
	Oct 2 2024, 10:59 AM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rS290603: Use lladdr_event to propagate gratiotus arp.

Summary

Currently we explicitly call ARP code from if_setlladdr() inside if.c.
We already have lladdr_event for internal subscribers like vlan.
Given that, add remaining hooks to make event work reliably (depends on D4004) and
convert ARP handler to use event instead of direct calls inside if.c

Test Plan

Create vlan on top of physical interface, run tcpdump for arp ethertype on both physical and vlan interfaces.
Change physical interface lladdr to different value, wait a bit and change it back.
You should see 2 arp who-has on both physical and vlan interfaces.

More complicated lagg-related examples exists in D4004.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

melifaro updated this revision to Diff 9748.Oct 27 2015, 8:55 PM

melifaro retitled this revision from to Use lladdr_event to propagate gratiotus arp..

melifaro updated this object.

melifaro edited the test plan for this revision. (Show Details)

melifaro added a reviewer: network.

melifaro added a parent revision: D4004: Yet another if_lagg lladdr/eventhandler fix..

Herald added a subscriber: imp. · View Herald TranscriptOct 27 2015, 8:55 PM

Looks reasonable for me.

This revision is now accepted and ready to land.Nov 9 2015, 9:09 AM

Pre-commit sync. Split announce logic from event handler. Register handler
only for default VNET.

This revision now requires review to proceed.Nov 9 2015, 9:55 AM

Closed by commit rS290603: Use lladdr_event to propagate gratiotus arp. (authored by melifaro). · Explain WhyNov 9 2015, 10:11 AM

This revision was automatically updated to reflect the committed changes.

koobs mentioned this in D4111: Fix lagg failover mode caused by missing node notifications.Nov 10 2015, 9:41 AM

melifaro mentioned this in D4102: Add link header precomputation for ethernet/infiniband. Make arp/ndp/bpf/flowtable use it..Dec 13 2015, 9:09 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

net/

13 lines

7 lines

netgraph/

3 lines

3 lines

netinet/

31 lines

Diff 10058

head/sys/net/if.c

Loading...

head/sys/net/if_vlan.c

Loading...

head/sys/netgraph/ng_eiface.c

Loading...

head/sys/netgraph/ng_ether.c

Loading...

head/sys/netinet/if_ether.c

Loading...