Page MenuHomeFreeBSD
Differential D4018

Build and install .debug files by default
ClosedPublic
Actions

Authored by emaste on Oct 27 2015, 8:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 9, 10:23 PM
Unknown Object (File)
Fri, Dec 6, 2:50 PM
Unknown Object (File)
Sun, Dec 1, 11:13 AM
Unknown Object (File)
Sun, Nov 24, 1:15 AM
Unknown Object (File)
Oct 19 2024, 3:31 AM
Unknown Object (File)
Oct 19 2024, 3:31 AM
Unknown Object (File)
Oct 19 2024, 3:31 AM
Unknown Object (File)
Oct 19 2024, 3:11 AM
View All 99 Files
Subscribers
bdrewery
gjb
imp

Details

Reviewers
eadler
jhb
vangyzen
bdrewery
Commits
rS291955: Build and install userland .debug files by default

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 9747.Oct 27 2015, 8:55 PM
emaste retitled this revision from to Build and install .debug files by default.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: jhb, vangyzen.
Herald added a subscriber: bdrewery. · View Herald TranscriptOct 27 2015, 8:55 PM
emaste added a subscriber: imp.Oct 27 2015, 8:56 PM
emaste added inline comments.
share/mk/bsd.opts.mk
89 ↗(On Diff #9747)

@imp I'm not sure why this is here -- DEBUG_FILES is recent enough that I don't expect NO_DEBUG_FILES= to be used anywhere

vangyzen accepted this revision.Oct 27 2015, 8:56 PM
vangyzen edited edge metadata.
This revision is now accepted and ready to land.Oct 27 2015, 8:56 PM
bdrewery accepted this revision.Oct 27 2015, 8:57 PM
bdrewery added a reviewer: bdrewery.
gjb added a subscriber: gjb.Oct 27 2015, 9:20 PM

Concerns about enabling this by default were raised in the past, when I was going to merge the /projects/release-install-debug branch back to /head.

https://lists.freebsd.org/pipermail/freebsd-current/2015-February/054459.html

gjb removed a subscriber: gjb.Oct 27 2015, 9:21 PM
emaste added a comment.Oct 27 2015, 9:46 PM

Comparison between WITHOUT_DEBUG_FILES and WITH_DEBUG_FILES

make -j16 WITHOUT_DEBUG_FILES=yes WITHOUT_LLDB=yes buildworld  12584.44s user 2675.79s system 1262% cpu 20:08.83 total
% du -sh /scratch/tmp/emaste/obj/scratch/tmp/emaste/freebsd/         
2.4G    /scratch/tmp/emaste/obj/scratch/tmp/emaste/freebsd/                     

make -j16 WITH_DEBUG_FILES=yes WITHOUT_LLDB=yes buildworld  13025.79s user 2734.26s system 1263% cpu 20:47.49 total
% du -sh /scratch/tmp/emaste/obj/scratch/tmp/emaste/freebsd/         
4.3G    /scratch/tmp/emaste/obj/scratch/tmp/emaste/freebsd/
eadler accepted this revision.Oct 28 2015, 9:28 AM
eadler added a reviewer: eadler.
emaste added a subscriber: gjb.Nov 26 2015, 9:37 PM

I'm waiting on @gjb to commit the changes from the release-install-debug branch to commit this.

Closed by commit rS291955: Build and install userland .debug files by default (authored by emaste). · Explain WhyDec 7 2015, 7:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
7 lines
share/
mk/
2 lines

Diff 10887

View Options

head/UPDATING

Loading...
View Options

head/share/mk/bsd.opts.mk

Loading...