emulators/virtualbox-ose: fix build on 12.x - no mempcpy

[vvd]

Summary

1. There are no mempcpy on 12, on 13 before 1300513 and on 14 before 1400026.

Log with error is here: https://portsfallout.com/fallout?port=emulators%2Fvirtualbox-ose%24

2. 12 have llvm11 in base after 1203502 (llvm12 after 1203503 and llvm13 after 1203505), so not need to force build with llvm11 from ports.

Tested build in poudriere on 12.4, 13.1 and 13.2.

[fuz]

LGTM

[arrowd]

What's the point in fixing unsupported versions of 13 and 14?

[vvd]

In D40163#914751, @arrowd wrote:

What's the point in fixing unsupported versions of 13 and 14?

${OSVERSION} < 1300513

Fixed supported 12 (and some old 13). Anyway this condition must exist and better to be < 1300513, than < 1300000.

${OSVERSION} >= 1400000 && ${OSVERSION} < 1400026

I don't know what versions of 14-CURRENT are supported. Before release all 14 are unsupported isn't it? But a lot of ports have patches for different versions of 14.

${OSVERSION} < 1203502 || ${OSVERSION} >= 1300000 && ${OSVERSION} < 1300109

Just remove from workaround supported 12.4+ and keep other part as it was before this patch.

P.S. Oh my english…

[arrowd]

@rene what do you think about this?

[fuz]

See this page for which FreeBSD releases are currently in support: https://www.freebsd.org/security/#sup
Everything older than that needs not be considered.

[vvd]

In D40163#914756, @fuz wrote:

See this page for which FreeBSD releases are currently in support: https://www.freebsd.org/security/#sup
Everything older than that needs not be considered.

There are no 14.

[rene]

In D40163#914757, @vvd wrote:

In D40163#914756, @fuz wrote:

See this page for which FreeBSD releases are currently in support: https://www.freebsd.org/security/#sup
Everything older than that needs not be considered.

There are no 14.

That is what the "main" branch is, which will soon become stable/14 and 14.0

But indeed you will see all kinds of versions for 14000xx (and soon 15000xx) for "main"/ CURRENT.

[rene]

emulators/virtualbox-ose/Makefile

215

13000513 is 13.0-STABLE which is end-of-life, and 1400026 looks like an old CURRENT to me, so this patch is probably obsolete.

223

As this conditional now only aplies to end-of-life versions of FreeBSD it can probably be removed.

[vvd]

emulators/virtualbox-ose/Makefile

215

${OSVERSION} < 1300513 is for 12 too!
The patch is special for 12 - build error at https://portsfallout.com/fallout?port=emulators%2Fvirtualbox-ose%24.

1400026 is old current, but I don't know what 14 are supported.

If you insist, I'll remove: ${OSVERSION} >= 1400000 && ${OSVERSION} < 1400026.

223

Update of this block of "if" is in this PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270189

12.4 is still supported and this patch add build with base llvm13 instead of 11 from ports.

[vvd]

In D40163#914934, @rene wrote:

In D40163#914757, @vvd wrote:

In D40163#914756, @fuz wrote:

See this page for which FreeBSD releases are currently in support: https://www.freebsd.org/security/#sup
Everything older than that needs not be considered.

There are no 14.

That is what the "main" branch is, which will soon become stable/14 and 14.0

But indeed you will see all kinds of versions for 14000xx (and soon 15000xx) for "main"/ CURRENT.

I know version numbers in FreeBSD and about delayed release 14 too.
So before 14 released all > 1400000 "regarded" as supported.

[rene]

emulators/virtualbox-ose/Makefile

215

${OSVERSION} < 1300513 is for 12 too!
The patch is special for 12 - build error at https://portsfallout.com/fallout?port=emulators%2Fvirtualbox-ose%24.

Ah, missed that.

1400026 is old current, but I don't know what 14 are supported.

If you insist, I'll remove: ${OSVERSION} >= 1400000 && ${OSVERSION} < 1400026.

1400026 is from July 2021 (https://cgit.freebsd.org/src/commit/?id=fad3f322efb53d4924fdda34f9f23f881659c269), so probably safe to drop. But it could also be removed wholesale when 14.0 goes out of support.

[vvd]

emulators/virtualbox-ose/Makefile

215

1400026 is from July 2021

Ye, I know: https://docs.freebsd.org/en/books/porters-handbook/versions/

So what is the decission: commit patch as is or do you have suggestions how to change it?

[vvd]

Can I commit this patch and begin to work on more important patch for fix https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270189 ?

[rene]

In D40163#915675, @vvd wrote:

Can I commit this patch and begin to work on more important patch for fix https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270189 ?

Sure, as fuz already approved it.