Page MenuHomeFreeBSD
Differential D40084

LinuxKPI: fix WRITE_ONCE()
ClosedPublic
Actions

Authored by bz on May 13 2023, 3:37 PM.
Tags
None
Referenced Files
F108208802: D40084.diff
Wed, Jan 22, 4:16 PM
Unknown Object (File)
Sat, Jan 11, 2:00 AM
Unknown Object (File)
Fri, Jan 10, 8:51 PM
Unknown Object (File)
Thu, Jan 9, 1:55 PM
Unknown Object (File)
Thu, Jan 9, 8:56 AM
Unknown Object (File)
Thu, Jan 9, 7:54 AM
Unknown Object (File)
Tue, Jan 7, 8:04 PM
Unknown Object (File)
Tue, Jan 7, 7:53 PM
View All 46 Files
Subscribers
emaste
• hselasky
imp

Details

Reviewers
jhb
brooks
• hselasky
Group Reviewers
linuxkpi
Commits
rG584bd868b4e4: LinuxKPI: fix WRITE_ONCE()
rG046d8d89ed19: LinuxKPI: fix WRITE_ONCE(), remove ACCESS_ONCE()
Summary

Fix a gcc warning: to be safe all intermediate pointers in cast from
'...' to '...' must be 'const' qualified [-Wcast-qual].
Doing what is essentially a __DECONST() adding the uintptr_t gets
rid of the massive amount of warnings we get in LinuxKPI and lets
us see the actual problems a lot better.
This is a follow-up to 74e908b3c63b28de1d590dc42502fbe959a6da2e which
fixed READ_ONCE().

Suggested by: jhb
MFC after: 10 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz created this revision.May 13 2023, 3:37 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptMay 13 2023, 3:37 PM
bz requested review of this revision.May 13 2023, 3:37 PM
Harbormaster completed remote builds in B51479: Diff 121928.May 13 2023, 3:37 PM
• hselasky added a reviewer: brooks.May 13 2023, 6:53 PM
• hselasky added a subscriber: • hselasky.
• hselasky added inline comments.
sys/compat/linuxkpi/common/include/linux/compiler.h
91

Hi,

ACCESS_ONCE() used to be a valid Linux API:

Documentation/RCU/RTFP.txt: ACCESS_ONCE().

But I think it is obsolete. Maybe say something about that in the commit message!

--HPS

93

This also works for CheriBSD and capability pointers?

jhb added inline comments.May 20 2023, 5:32 PM
sys/compat/linuxkpi/common/include/linux/compiler.h
93

Yes.

• hselasky accepted this revision.May 21 2023, 4:38 PM

Looks good!

This revision is now accepted and ready to land.May 21 2023, 4:38 PM
Closed by commit rG046d8d89ed19: LinuxKPI: fix WRITE_ONCE(), remove ACCESS_ONCE() (authored by bz). · Explain WhyMay 21 2023, 11:14 PM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rG046d8d89ed19: LinuxKPI: fix WRITE_ONCE(), remove ACCESS_ONCE().
bz added a commit: rG584bd868b4e4: LinuxKPI: fix WRITE_ONCE().Jun 26 2023, 12:09 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
4 lines

Diff 122196

View Options

sys/compat/linuxkpi/common/include/linux/compiler.h

Loading...