Page MenuHomeFreeBSD

boolean_t: change to unsigned int to avoid signed bitfield warnings
ClosedPublic

Authored by dim on Apr 21 2023, 7:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 13, 3:01 AM
Unknown Object (File)
Mon, Oct 13, 3:01 AM
Unknown Object (File)
Mon, Oct 13, 3:00 AM
Unknown Object (File)
Sun, Oct 12, 3:08 PM
Unknown Object (File)
Sat, Oct 11, 10:43 PM
Unknown Object (File)
Sep 14 2025, 6:04 PM
Unknown Object (File)
Sep 8 2025, 11:59 PM
Unknown Object (File)
Aug 19 2025, 6:04 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dim requested review of this revision.Apr 21 2023, 7:11 PM
sys/contrib/openzfs/module/os/freebsd/zfs/zfs_ioctl_os.c
62

Actually I might need to submit this one separately, but it already got committed upstream as https://github.com/openzfs/zfs/commit/62cc9d4f6b5ad3a16b97f6389828b20331863f40

Humm, maybe commit all the mismatch fixes separate from the change to switch boolean_t from int to unsigned int?

This revision is now accepted and ready to land.Apr 25 2023, 4:43 PM
In D39753#906076, @jhb wrote:

Humm, maybe commit all the mismatch fixes separate from the change to switch boolean_t from int to unsigned int?

First the mismatch fixes, then finally the boolean-to-unsigned one. Got it.

Humm, maybe commit all the mismatch fixes separate from the change to switch boolean_t from int to unsigned int?

That sounds reasonable to me too.

Humm, maybe commit all the mismatch fixes separate from the change to switch boolean_t from int to unsigned int?

That sounds reasonable to me too.

I've split it in three:

  1. openzfs fix (which was upstreamed)
  2. sys/vm fixes
  3. sys/sys/types.h change boolean_t to unsigned