boolean_t: change to unsigned int to avoid signed bitfield warnings
ClosedPublic
Actions

Authored by dim on Apr 21 2023, 7:11 PM.

Details

Reviewers

emaste
jhb
imp

Commits

rG3f527b4b8fd5: vm: fix a number of functions to match the expected prototypes
rGc3da468befd3: boolean_t: change to unsigned int to avoid signed bitfield warnings
rGf6d7ceb2baa3: boolean_t: change to unsigned int to avoid signed bitfield warnings
rG35d8e035e22f: vm: fix a number of functions to match the expected prototypes
rG387546f14b63: zfs: make zfs_vfs_held() definition consistent with declaration
rG3029b0b0e9d6: boolean_t: change to unsigned int to avoid signed bitfield warnings
rGf74be55e3045: vm: fix a number of functions to match the expected prototypes
rG64b5d74fffc8: zfs: make zfs_vfs_held() definition consistent with declaration

Summary

This also fixes a number of function declarations and definitions to
match the expected prototypes.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dim created this revision.Apr 21 2023, 7:11 PM

Herald added a subscriber: delphij. · View Herald TranscriptApr 21 2023, 7:11 PM

dim requested review of this revision.Apr 21 2023, 7:11 PM

Harbormaster completed remote builds in B51104: Diff 120830.Apr 21 2023, 7:11 PM

dim added inline comments.Apr 21 2023, 7:14 PM

sys/contrib/openzfs/module/os/freebsd/zfs/zfs_ioctl_os.c
62	Actually I might need to submit this one separately, but it already got committed upstream as https://github.com/openzfs/zfs/commit/62cc9d4f6b5ad3a16b97f6389828b20331863f40

emaste added a subscriber: markj.Apr 21 2023, 8:42 PM

Humm, maybe commit all the mismatch fixes separate from the change to switch boolean_t from int to unsigned int?

This revision is now accepted and ready to land.Apr 25 2023, 4:43 PM

In D39753#906076, @jhb wrote:

Humm, maybe commit all the mismatch fixes separate from the change to switch boolean_t from int to unsigned int?

First the mismatch fixes, then finally the boolean-to-unsigned one. Got it.

Closed by commit rG64b5d74fffc8: zfs: make zfs_vfs_held() definition consistent with declaration (authored by dim). · Explain WhyApr 25 2023, 6:00 PM

This revision was automatically updated to reflect the committed changes.

dim added a commit: rG64b5d74fffc8: zfs: make zfs_vfs_held() definition consistent with declaration.

dim added a commit: rGf74be55e3045: vm: fix a number of functions to match the expected prototypes.

dim added a commit: rG3029b0b0e9d6: boolean_t: change to unsigned int to avoid signed bitfield warnings.

Humm, maybe commit all the mismatch fixes separate from the change to switch boolean_t from int to unsigned int?

That sounds reasonable to me too.

In D39753#906259, @emaste wrote:

Humm, maybe commit all the mismatch fixes separate from the change to switch boolean_t from int to unsigned int?

That sounds reasonable to me too.

I've split it in three: