These flags are TCP specific. While here, make also several LRO
internal functions to pass tcpcb pointer instead of inpcb one.
Details
Details
- Reviewers
rrs cc - Group Reviewers
transport - Commits
- rGc3c20de3b2d1: tcp: move HPTS/LRO flags out of inpcb to tcpcb
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 51039 Build 47930: arc lint + arc unit
Event Timeline
| sys/netinet/tcp_var.h | ||
|---|---|---|
| 844 | I think I have commented before in a different patch review. This TF2_TCP_ACCOUNTING value should be 0x00001000, not 0x00010000. Please correct it in a separate patch, so that all the following defines can be in order. | |
| sys/netinet/tcp_var.h | ||
|---|---|---|
| 844 | But on a second thought, I think I can submit a patch to simply correct it. :) | |
| sys/netinet/tcp_var.h | ||
|---|---|---|
| 844 | I created https://reviews.freebsd.org/D39716 to correct this TF2_TCP_ACCOUNTING value. | |
Comment Actions
I think it's value should be 0x1000. So that future new defines can have more space available.
Comment Actions
Not sure what is going on with this Phabricator page. Actually, this change is committed after my commit rG8aa2be695e0c from https://reviews.freebsd.org/D39716. The new TF2 defines in tcp_var.h are in order. Thanks for taking care of this.