clang: Enable -Wdeprecated-non-prototype by default.
ClosedPublic
Actions

Does it make sense to do the kernel and userland separately? I plan to make my way through all of the userland changes for review, but we can probably get the kernel done right away.

This revision is now accepted and ready to land.Apr 12 2023, 4:18 PM

does this affect ports?

In D39535#899954, @mjg wrote:

does this affect ports?

I think that most ports would not be affected but it will affect the small handful of ports that use the base system share/mk infrastructure, and it probably needs an exp-run. Perhaps another reason to separate the kernel part and commit it independently.

Hm are we now totally clean on those warnings?

In D39535#900050, @dim wrote:

Hm are we now totally clean on those warnings?

After the fixes in the attached "stack" I can now do a 'make tinderbox'.

In D39535#899919, @emaste wrote:

Does it make sense to do the kernel and userland separately? I plan to make my way through all of the userland changes for review, but we can probably get the kernel done right away.

I'm not even sure I had any cases in the kernel I had to fix at all?

I'm not even sure I had any cases in the kernel I had to fix at all?

I thought maybe smbfs but it looks like that code is used only by mount_smbfs (and related things perhaps).

Re-enabling the warnings now will ensure no more of these will sneak in, so LGTM :)

jhb added a parent revision: D39670: ee: Use C89 function definitions..Apr 18 2023, 6:53 PM

Exp-run requested at https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270919

exp-run only found two port breakages for misc/ctm and mail/rblcheck. These should be easy to fix.

I've opened a PR for both to fix the issues upstream (https://github.com/freebsd/ctm/pull/1 and https://github.com/logic/rblcheck/pull/2) and D39780 includes the patch from the second one. I will create a review to update the mail/ctm port once the first PR is accepted and lands. I think it's fine to merge the patch to src now though.

jhb removed a child revision: D39780: mail/rblcheck: Use a C89 function declaration for main..Apr 25 2023, 9:05 PM

jhb added parent revisions: D39819: mail/ctm: Fix build with -Wdeprecated-non-prototype., D39780: mail/rblcheck: Use a C89 function declaration for main..

Closed by commit rG7aab8fc5c5f0: clang: Enable -Wdeprecated-non-prototype by default. (authored by jhb). · Explain WhyApr 25 2023, 9:10 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG7aab8fc5c5f0: clang: Enable -Wdeprecated-non-prototype by default..