Page MenuHomeFreeBSD

Use macros CTLFLAG_R[DW]TUN
ClosedPublic

Authored by zlei on Apr 8 2023, 2:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 10:29 AM
Unknown Object (File)
Sat, Oct 11, 10:28 AM
Unknown Object (File)
Sat, Oct 11, 10:28 AM
Unknown Object (File)
Sat, Oct 11, 10:28 AM
Unknown Object (File)
Sat, Oct 11, 2:41 AM
Unknown Object (File)
Wed, Oct 8, 5:29 PM
Unknown Object (File)
Fri, Oct 3, 4:31 PM
Unknown Object (File)
Thu, Oct 2, 9:47 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a reviewer: Restricted Owners Package.Apr 8 2023, 2:03 PM
zlei requested review of this revision.Apr 8 2023, 2:03 PM

Hi @kp , I'd like to commit them separately so it will easy to MFC.

Should all of them have same meta Differential Revision: ?

Change looks good, but the commit message should be more descriptive:

Use the existing CTLFLAG_RDTUN and CTLFLAG_RWTUN flag definitions when possible, instead of separated flags.

No functional change intended.

Change looks good, but the commit message should be more descriptive:

Use the existing CTLFLAG_RDTUN and CTLFLAG_RWTUN flag definitions when possible, instead of separated flags.

Agreed. That sounds better than solely one line No functional change intended. .

No functional change intended.

In D39466#898395, @zlei wrote:

Hi @kp , I'd like to commit them separately so it will easy to MFC.

Should all of them have same meta Differential Revision: ?

Yeah, just point them all at this one.

This revision is now accepted and ready to land.Apr 10 2023, 4:06 PM
In D39466#898724, @kp wrote:
In D39466#898395, @zlei wrote:

Hi @kp , I'd like to commit them separately so it will easy to MFC.

Should all of them have same meta Differential Revision: ?

Yeah, just point them all at this one.

Phabricator is not smart. This review is closed by dc1c5138c325 and the revision history only reflect dc1c5138c325 .