Use macros CTLFLAG_R[DW]TUN
ClosedPublic
Actions

Authored by zlei on Apr 8 2023, 2:03 PM.

Details

Reviewers

• hselasky
erj

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
cam

Commits

Summary

No functional change intended.

MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.Apr 8 2023, 2:03 PM

Owners added a reviewer: Restricted Owners Package.Apr 8 2023, 2:03 PM

Herald added a reviewer: cam. · View Herald TranscriptApr 8 2023, 2:03 PM

Herald added subscribers: jhibbits, imp. · View Herald Transcript

zlei requested review of this revision.Apr 8 2023, 2:03 PM

Hi @kp , I'd like to commit them separately so it will easy to MFC.

Should all of them have same meta Differential Revision: ?

Change looks good, but the commit message should be more descriptive:

Use the existing CTLFLAG_RDTUN and CTLFLAG_RWTUN flag definitions when possible, instead of separated flags.

No functional change intended.

In D39466#898398, @hselasky wrote:

Change looks good, but the commit message should be more descriptive:

Use the existing CTLFLAG_RDTUN and CTLFLAG_RWTUN flag definitions when possible, instead of separated flags.

Agreed. That sounds better than solely one line No functional change intended. .

No functional change intended.

In D39466#898395, @zlei wrote:

Hi @kp , I'd like to commit them separately so it will easy to MFC.

Should all of them have same meta Differential Revision: ?

Yeah, just point them all at this one.

erj accepted this revision.Apr 10 2023, 4:06 PM

This revision is now accepted and ready to land.Apr 10 2023, 4:06 PM

Closed by commit rGdc1c5138c325: powerpc: Use the existing CTLFLAG_RDTUN and CTLFLAG_RWTUN flag definitions (authored by zlei). · Explain WhyApr 12 2023, 4:21 AM

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rGdc1c5138c325: powerpc: Use the existing CTLFLAG_RDTUN and CTLFLAG_RWTUN flag definitions.

zlei added a commit: rG69cb72b8728b: cam iosched: Use the existing CTLFLAG_RDTUN and CTLFLAG_RWTUN flag definitions.

zlei added a commit: rG5ff801810827: ice(4): Use the existing CTLFLAG_RWTUN flag definition.

zlei added a commit: rG8bd9afe9e182: bxe(4): Use CTLFLAG_RDTUN flag definition.

zlei added a commit: rGdeac4c7f0753: iicbus(4): Use the existing CTLFLAG_RWTUN flag definition.

zlei added a commit: rGc3c5e6c3e6c4: tarfs: Use the existing CTLFLAG_RWTUN flag definition.

In D39466#898724, @kp wrote:

In D39466#898395, @zlei wrote:

Hi @kp , I'd like to commit them separately so it will easy to MFC.

Should all of them have same meta Differential Revision: ?

Yeah, just point them all at this one.