netinet tests: test carp source MAC address
ClosedPublic
Actions

Authored by kp on Apr 6 2023, 4:12 PM.

Details

Reviewers

markj
melifaro

Group Reviewers

network
pfsense

Commits

rG5e2e3615d91f: netinet tests: test carp source MAC address

Summary

Ensure that (multicast) CARP packets are sent with the expected source
MAC address.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Apr 6 2023, 4:12 PM

Herald added subscribers: glebius, asomers, imp. · View Herald TranscriptApr 6 2023, 4:12 PM

kp requested review of this revision.Apr 6 2023, 4:12 PM

Harbormaster completed remote builds in B50799: Diff 119951.Apr 6 2023, 4:12 PM

kp mentioned this in D39445: tests: convert forwarding tests to python.Apr 6 2023, 4:17 PM

LGTM!

The only thing - it's probably worth running black, flake8 and reorder-python-imports on the test file to ensure consistent formatting.

This revision is now accepted and ready to land.Apr 7 2023, 10:11 AM

This revision was landed with ongoing or failed builds.Apr 7 2023, 3:58 PM

Closed by commit rG5e2e3615d91f: netinet tests: test carp source MAC address (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG5e2e3615d91f: netinet tests: test carp source MAC address.

Revision Contents
Changeset List

Path

Size

tests/

sys/

netinet/

Makefile

2 lines

carp.py

53 lines

Diff 119967

View Options

tests/sys/netinet/Makefile