bhyve: remove unnecessary const qualifier in acpi_device.h
ClosedPublic
Actions

Authored by corvink on Mar 29 2023, 1:24 PM.

Details

Reviewers

jhb
markj

Group Reviewers

bhyve

Commits

rG2a33e252a79c: bhyve: remove unnecessary const qualifier in acpi_device.h
rG404689908632: bhyve: remove unnecessary const qualifier in acpi_device.h

Summary

Those const qualifier declare that the function doesn't change the
values internally. It makes no sense to add them in the header file.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 50648
Build 47539: arc lint + arc unit

Event Timeline

corvink created this revision.Mar 29 2023, 1:24 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptMar 29 2023, 1:24 PM

corvink requested review of this revision.Mar 29 2023, 1:24 PM

Harbormaster completed remote builds in B50648: Diff 119607.Mar 29 2023, 1:24 PM

corvink added a child revision: D39319: bhyve: introduce acpi_device_emul struct.Mar 29 2023, 1:25 PM

markj accepted this revision as: markj.Mar 29 2023, 1:27 PM

This revision is now accepted and ready to land.Mar 29 2023, 1:27 PM

guest-patmaddox added a subscriber: guest-patmaddox.Mar 29 2023, 4:53 PM

Closed by commit rG404689908632: bhyve: remove unnecessary const qualifier in acpi_device.h (authored by corvink). · Explain WhyMar 30 2023, 11:06 AM

This revision was automatically updated to reflect the committed changes.

corvink added a commit: rG404689908632: bhyve: remove unnecessary const qualifier in acpi_device.h.

corvink added a commit: rG2a33e252a79c: bhyve: remove unnecessary const qualifier in acpi_device.h.Apr 6 2023, 6:11 AM

guest-patmaddox removed a subscriber: guest-patmaddox.Jul 29 2023, 5:38 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

acpi_device.h

16 lines

Diff 119607

View Options

usr.sbin/bhyve/acpi_device.h

bhyve: remove unnecessary const qualifier in acpi_device.hClosedPublicActions