Page MenuHomeFreeBSD

amd64 wakeup: recalculate ssb/rngds mitigations after APICs are woken
ClosedPublic

Authored by kib on Mar 29 2023, 12:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 28, 3:17 PM
Unknown Object (File)
Apr 12 2024, 10:29 AM
Unknown Object (File)
Apr 9 2024, 9:58 PM
Unknown Object (File)
Apr 9 2024, 8:27 PM
Unknown Object (File)
Apr 6 2024, 11:47 PM
Unknown Object (File)
Apr 4 2024, 1:07 AM
Unknown Object (File)
Jan 14 2024, 7:26 AM
Unknown Object (File)
Jan 13 2024, 7:44 AM

Details

Summary
APICs are needed to broadcast IPIs for MSR writes.

PR:     270489
Tested by:      dchagin

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib requested review of this revision.Mar 29 2023, 12:49 AM
dchagin added inline comments.
sys/amd64/acpica/acpi_wakeup.c
300–301

q just for curiosity: why to not move all of this below intr_resume?

This revision is now accepted and ready to land.Mar 29 2023, 8:42 AM

Fix the issue for me on my whiskeylake laptop.

Thanks.

kib marked an inline comment as done.

Move everything after APICs are resumed.

This revision now requires review to proceed.Mar 29 2023, 1:42 PM

Last version still work on my laptop.

sys/amd64/acpica/acpi_wakeup.c
299–300

It looks like this comment should move to before the identify_cpu_ext_features() call above.

kib marked an inline comment as done.Mar 29 2023, 2:26 PM
kib added inline comments.
sys/amd64/acpica/acpi_wakeup.c
300–301

I tried to be conservative and recalculate as much as possible right after identify_cpu().

This revision is now accepted and ready to land.Mar 29 2023, 2:30 PM

confirm last ver work on stable/13.2 Intel i5-8265U SSBD, IBPB, MCUOPT

Just FWIW the patch does fix the issue for me too. Thanks a lot everyone!