bhyve: Accept a variable-length string name for qemu_fwcfg_add_file.
ClosedPublic
Actions

Authored by jhb on Mar 22 2023, 6:01 PM.

Details

Reviewers

markj
corvink

Group Reviewers

bhyve

Commits

rG2c63333240f2: bhyve: Accept a variable-length string name for qemu_fwcfg_add_file.
rG61482760a0ca: bhyve: Accept a variable-length string name for qemu_fwcfg_add_file.

Summary

It is illegal (UB?) to pass a shorter array to a function argument
that takes a fixed-length array. Do a runtime check for names that
are too long via strlen() instead.

Reported by: GCC -Wstringop-overread

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 50524
Build 47415: arc lint + arc unit

Event Timeline

jhb created this revision.Mar 22 2023, 6:01 PM

Herald added a reviewer: bhyve. · View Herald TranscriptMar 22 2023, 6:01 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

jhb requested review of this revision.Mar 22 2023, 6:01 PM

Harbormaster completed remote builds in B50524: Diff 119266.Mar 22 2023, 6:01 PM

jhb added a child revision: D39212: bhyve: Don't return -ENOMEM from qemu_fwcfg_add_file..Mar 22 2023, 6:01 PM

jhb added a reviewer: corvink.Mar 22 2023, 6:02 PM

markj accepted this revision as: markj.Mar 22 2023, 6:31 PM

This revision is now accepted and ready to land.Mar 22 2023, 6:31 PM

Closed by commit rG61482760a0ca: bhyve: Accept a variable-length string name for qemu_fwcfg_add_file. (authored by jhb). · Explain WhyMar 22 2023, 7:36 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG61482760a0ca: bhyve: Accept a variable-length string name for qemu_fwcfg_add_file..

jhb added a commit: rG2c63333240f2: bhyve: Accept a variable-length string name for qemu_fwcfg_add_file..May 3 2023, 12:30 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

qemu_fwcfg.h

2 lines

qemu_fwcfg.c

6 lines

Diff 119266

View Options

usr.sbin/bhyve/qemu_fwcfg.h