Page MenuHomeFreeBSD

net: refactor if_clone.c #1
ClosedPublic

Authored by melifaro on Mar 13 2023, 10:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 19 2024, 1:22 PM
Unknown Object (File)
Feb 19 2024, 1:22 PM
Unknown Object (File)
Feb 19 2024, 1:22 PM
Unknown Object (File)
Feb 19 2024, 1:18 PM
Unknown Object (File)
Feb 19 2024, 6:43 AM
Unknown Object (File)
Feb 10 2024, 5:44 AM
Unknown Object (File)
Jan 14 2024, 7:21 AM
Unknown Object (File)
Dec 27 2023, 4:19 PM
Subscribers

Details

Summary
  • Add ifc_find_cloner()
  • Rename current ifc_find_cloner() to ifc_find_cloner_vnet()
  • Add ifc_find_cloner_match()

This change simplifies the code a bit and reduces the diff to
the netlink interface cloners merge (D39032).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Two non-blocking remarks.

sys/net/if_clone.c
200

That declaration probably needs to be before int error; in line 196, and separated from the assignment.

296

Would ifc_find_cloner_in_vnet() be better?

This revision is now accepted and ready to land.Mar 13 2023, 12:51 PM
glebius added inline comments.
sys/net/if_clone.c
200

+1 on that

This revision was automatically updated to reflect the committed changes.