sysutils/rundeck3: update to 3.4.10
ClosedPublic
Actions

Authored by fuz on Feb 16 2023, 1:11 PM.

Details

Reviewers

eduardo
flo

Commits

R11:85e9f07dc482: sysutils/rundeck3: update to 3.4.10
R11:df09fa81db51: sysutils/rundeck3: update to 3.4.10

Summary

sysutils/rundeck3: update to 3.4.10

 - use options -H amd -o to daemon(8) for logging

Changelog: https://docs.rundeck.com/docs/history/3_4_x/version-3.4.10.html

MFH:		2023Q1
PR:		261748
Reported by:	ruben@verweg.com
Approved by:	... (mentor)

MFH due to security fix (see D38636).

Test Plan

Tested with Poudriere on i386 amd64 FreeBSD 12.4 13.1. Arm64 tests pending.
See test results at: http://fuz.su/~fuz/freebsd/batch2

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fuz created this revision.Feb 16 2023, 1:11 PM

Herald added a subscriber: mat. · View Herald TranscriptFeb 16 2023, 1:11 PM

fuz requested review of this revision.Feb 16 2023, 1:11 PM

Harbormaster completed remote builds in B49846: Diff 117443.Feb 16 2023, 1:11 PM

fuz edited the summary of this revision. (Show Details)Feb 16 2023, 1:13 PM

flo mentioned this in D38636: security/vuxml: document log4j vulnerability in sysutils/rundeck3.Feb 17 2023, 9:04 AM

ARM64 test results have arrived.

eduardo added inline comments.Feb 18 2023, 9:18 AM

sysutils/rundeck3/Makefile
35	Is .include <bsd.port.pre.mk> and .include <bsd.port.post.mk> needed around if conditions? .if ${RUNDECK_USER} == "rundeck" USERS= rundeck .endif .if ${RUNDECK_GROUP} == "rundeck" GROUPS= rundeck .endif portlint doesn't complain about it and port seems to build fine.

This is an artifact of an obsolete ${OSVERSION} check from an earlier version of the patch. Thank you for catching this. Will remove it.

Remove bsd.port.pre.mk.

Harbormaster completed remote builds in B49875: Diff 117532.Feb 18 2023, 9:55 AM

The proposed commit message is now:

sysutils/rundeck3: update to 3.4.10
    
 - use options -H amd -o to daemon(8) for logging
    
Changelog: https://docs.rundeck.com/docs/history/3_4_x/version-3.4.10.html
    
MFH:            2023Q1
PR:             261748
Security:       27c822a0-addc-11ed-a9ee-dca632b19f10
Reported by:    ruben@verweg.com
Approved by:    ... (mentor)

mat added inline comments.Feb 18 2023, 10:04 AM

sysutils/rundeck3/Makefile
2–7	This feels a bit strange, the definition of `DISTNAME` should be dropped, and the `-` added to `DISTVERSIONSUFFIX` instead.

In D38634#879856, @fuz wrote:
The proposed commit message is now:
sysutils/rundeck3: update to 3.4.10
    
 - use options -H amd -o to daemon(8) for logging

The commit message should explain WHY things are done, so, probably more like

use daemon(8)'s logging facilities instead of shell redirection so that log rotation can happen easily.

mat added inline comments.Feb 18 2023, 10:09 AM

sysutils/rundeck3/Makefile
43–46	In ports, we don't usually quote strings.

fuz added inline comments.Feb 18 2023, 10:55 AM

sysutils/rundeck3/Makefile
2–7	This is the update as the maintainer has submitted it. The maintainer has since rescinded maintainership. Would you like me to change this and the other thing with the quotes? I usually try not to change things that are not outright wrong as the maintainer probably had some sort of intent when writing the port like this.

mat added inline comments.Feb 18 2023, 11:06 AM

sysutils/rundeck3/Makefile
2–7	Well, the one reason we have committers is so that submissions gets screened and fixed to be in line with our policies. You don't need to ask the maintainer for any approval to change their submission so that they fit our guidelines. The intent of the maintainer, unless made explicit, is irrelevant.