User Details
- User Since
- May 11 2014, 9:38 AM (472 w, 2 h)
Fri, May 26
Mon, May 22
Sun, May 21
Tue, May 2
Apr 24 2023
Apr 16 2023
Apr 15 2023
Mar 30 2023
Mar 24 2023
Mar 16 2023
Mar 3 2023
Feb 27 2023
Approved. Thanks for adding the UPDATING entry.
Feb 26 2023
Approved.
I think this looks fine. What @diizzy notes comes down to personal preference I guess. Approved, with or without changes to the do-install target.
I left a comment in the PR, i think we should add an UPDATING entry. Other than that I think this looks good.
Feb 23 2023
Approved. I realize that this is one more of those not documented but usually we do it this way things. When we use blanket approval it's often noted as such. i.e. portmgr (blanket, build fix), otherwise it looks like portmgr actively approved this commit, which I *think* the did not?
Approved
This is kind of redundant information, i would leave it out
- make makesum
- new plist entries
Feb 20 2023
Yeah, forgot the tag. Ok, apparently I never noticed.
Are the bundled libraries always used? I.e. the ones that the port depended on were unused? Otherwise we should keep the dependencies.
Was this discussed with the maintainer? I'm 50:50 whether this is infrastructure works that we as committers are expected to correct, or if this should be run by the maintainer. For sysutils/rundeck2 it's clear as it has been unmaintained upstream for a long time.
Approved. This looks like something that might be MFH'ed?
Approved. You can put something like (maintainer, via private mail). That's how it's done from time to time.
Approved.
Approved. I was going to comment on the commit message, that it should describe why something is done and not what is done, but I see it was also submitted by the maintainer.
"Submitter is first time maintainer." I've never seen this mentioned. I don't think it's necessary to mention this, but it doesn't hurt of course. Personally I would leave it out.
Looks good. Approved
Feb 19 2023
Approved
Approved.
Feb 17 2023
Feb 16 2023
Approved
I see you add a Reported by: tag on all maintainer submitted patches. That is relatively uncommon. I see that fernape seems to do this. Usually ever since switching to git we just set the author on the commit. Reported by: is usually for when someone just reported something but did not provide a patch.
Approved. The PR states that it should be MFH'ed. I don't see this in the commit message template, but if you want to that's approved too, as a simple build fix.