Page MenuHomeFreeBSD
Differential D38449

kern/intr: switch intr_event_handle() to return stray count
Needs ReviewPublic
Actions

Authored by ehem_freebsd_m5p.com on Feb 8 2023, 9:04 PM.
Tags
None
Referenced Files
F131926417: D38449.diff
Sun, Oct 12, 6:37 AM
F131908300: D38449.diff
Sun, Oct 12, 3:32 AM
Unknown Object (File)
Mon, Sep 29, 7:39 PM
Unknown Object (File)
Sep 11 2025, 8:43 PM
Unknown Object (File)
Sep 11 2025, 4:29 PM
Unknown Object (File)
Aug 21 2025, 7:55 PM
Unknown Object (File)
Aug 14 2025, 11:55 PM
Unknown Object (File)
Aug 14 2025, 11:33 PM
View All 64 Files
Subscribers
imp
olce

Details

Reviewers
markj
Summary

Comparable to the current situation. Minor savings, one caller simply
passes the count directly through.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 49636
Build 46526: arc lint + arc unit

Event Timeline

ehem_freebsd_m5p.com created this revision.Feb 8 2023, 9:04 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 8 2023, 9:04 PM
ehem_freebsd_m5p.com requested review of this revision.Feb 8 2023, 9:04 PM
Harbormaster completed remote builds in B49636: Diff 116808.Feb 8 2023, 9:04 PM
ehem_freebsd_m5p.com added a parent revision: D38448: kern/intr: add flags for multi-processor interrupts.Feb 8 2023, 9:34 PM
ehem_freebsd_m5p.com added a reviewer: markj.Feb 8 2023, 9:38 PM

This works well with D35519/D35529/D35546. The whole stack turns to returning stray counts, which are rather more useful than 0 or EINVAL. Notably for a PPI interrupt, limited reporting of strays can be rather more consistent.

ehem_freebsd_m5p.com added a parent revision: D41430: kern/intr: add interrupt counters to intr_isrc.Aug 11 2023, 7:51 PM
ehem_freebsd_m5p.com removed a parent revision: D38448: kern/intr: add flags for multi-processor interrupts.Aug 11 2023, 7:59 PM
ehem_freebsd_m5p.com abandoned this revision.Dec 13 2024, 3:30 AM
Herald added a subscriber: olce. · View Herald TranscriptDec 13 2024, 3:30 AM
ehem_freebsd_m5p.com reclaimed this revision.Mon, Oct 6, 5:48 PM

A more recent version of the series is now on Github as #1301. Note that is marked as a draft since something else is higher priority right now.

Revision Contents
Changeset List

PathSize
sys/
kern/
18 lines
sys/
2 lines
x86/
x86/
7 lines

Diff 116808

View Options

sys/kern/kern_intr.c

Loading...
View Options

sys/sys/interrupt.h

Loading...
View Options

sys/x86/x86/intr_machdep.c

Loading...