Page MenuHomeFreeBSD
Differential D38089

vt(4): Return errors from `vt_{,de}allocate()`
ClosedPublic
Actions

Authored by dumbbell on Jan 16 2023, 7:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 22 2025, 2:03 PM
Unknown Object (File)
Jan 26 2025, 2:04 PM
Unknown Object (File)
Jan 18 2025, 1:42 AM
Unknown Object (File)
Jan 10 2025, 12:38 PM
Unknown Object (File)
Jan 10 2025, 9:21 AM
Unknown Object (File)
Oct 12 2024, 1:47 AM
Unknown Object (File)
Sep 13 2024, 10:38 PM
Unknown Object (File)
Sep 10 2024, 12:19 PM
View All 48 Files
Subscribers
imp

Details

Reviewers
manu
Commits
rGa0bf2c3aab9d: vt(4): Return errors from `vt_{,de}allocate()`
rG29ab19455484: vt(4): Return errors from `vt_{,de}allocate()`
Summary

This is useful to the DRM drivers to let them know if a device is effectively used by the console.

This is part of the update of the DRM drivers to Linux 5.13.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
dev/
vt/
hw/
fb/
10 lines
4 lines
16 lines

Diff 115751

View Options

sys/dev/vt/hw/fb/vt_fb.c

Show First 20 Lines • Show All 83 Lines • ▼ Show 20 Lines
#define U8_C(x) x ## U #define U8_C(x) x ## U
#define S16_C(x) x #define S16_C(x) x
#define U16_C(x) x ## U #define U16_C(x) x ## U
#define S32_C(x) x #define S32_C(x) x
#define U32_C(x) x ## U #define U32_C(x) x ## U
#define S64_C(x) x ## LL #define S64_C(x) x ## LL
#define U64_C(x) x ## ULL #define U64_C(x) x ## ULL
/*
* BUILD_BUG_ON() can happen inside functions where _Static_assert() does not
* seem to work. Use old-schoold-ish CTASSERT from before commit
* a3085588a88fa58eb5b1eaae471999e1995a29cf but also make sure we do not
* end up with an unused typedef or variable. The compiler should optimise
* it away entirely.
*/
#define _O_CTASSERT(x) _O__CTASSERT(x, __LINE__)
#define _O__CTASSERT(x, y) _O___CTASSERT(x, y)
#define _O___CTASSERT(x, y) while (0) { \
hselaskyUnsubmitted
Not Done
Inline Actions

Should this be enclosed with while (0) and not "do { } while (0) "?

hselasky: Should this be enclosed with while (0) and not "do { } while (0) "?
bzAuthorUnsubmitted
Done
Inline Actions

Would a while (0) { } be optimized out without ever entering the block because it can never happen?

bz: Would a while (0) { } be optimized out without ever entering the block because it can never…
hselaskyUnsubmitted
Not Done
Inline Actions

Yes, with -O2, but after parsing the code. So I believe any asserts will trigger.

hselasky: Yes, with -O2, but after parsing the code. So I believe any asserts will trigger.
typedef char __assert_line_ ## y[(x) ? 1 : -1]; \
__assert_line_ ## y _x; \
_x[0] = '\0'; \
}
#define BUILD_BUG() do { CTASSERT(0); } while (0) #define BUILD_BUG() do { CTASSERT(0); } while (0)
#define BUILD_BUG_ON(x) CTASSERT(!(x)) #define BUILD_BUG_ON(x) _O_CTASSERT(!(x))
#define BUILD_BUG_ON_MSG(x, msg) BUILD_BUG_ON(x) #define BUILD_BUG_ON_MSG(x, msg) BUILD_BUG_ON(x)
#define BUILD_BUG_ON_NOT_POWER_OF_2(x) BUILD_BUG_ON(!powerof2(x)) #define BUILD_BUG_ON_NOT_POWER_OF_2(x) BUILD_BUG_ON(!powerof2(x))
#define BUILD_BUG_ON_INVALID(expr) while (0) { (void)(expr); } #define BUILD_BUG_ON_INVALID(expr) while (0) { (void)(expr); }
extern const volatile int lkpi_build_bug_on_zero; extern const volatile int lkpi_build_bug_on_zero;
#define BUILD_BUG_ON_ZERO(x) ((x) ? lkpi_build_bug_on_zero : 0) #define BUILD_BUG_ON_ZERO(x) ((x) ? lkpi_build_bug_on_zero : 0)
#define BUG() panic("BUG at %s:%d", __FILE__, __LINE__) #define BUG() panic("BUG at %s:%d", __FILE__, __LINE__)
▲ Show 20 Lines • Show All 538 Lines • Show Last 20 Lines
View Options

sys/dev/vt/vt.h

Show First 20 Lines • Show All 83 Lines • ▼ Show 20 Lines
#define U8_C(x) x ## U #define U8_C(x) x ## U
#define S16_C(x) x #define S16_C(x) x
#define U16_C(x) x ## U #define U16_C(x) x ## U
#define S32_C(x) x #define S32_C(x) x
#define U32_C(x) x ## U #define U32_C(x) x ## U
#define S64_C(x) x ## LL #define S64_C(x) x ## LL
#define U64_C(x) x ## ULL #define U64_C(x) x ## ULL
/*
* BUILD_BUG_ON() can happen inside functions where _Static_assert() does not
* seem to work. Use old-schoold-ish CTASSERT from before commit
* a3085588a88fa58eb5b1eaae471999e1995a29cf but also make sure we do not
* end up with an unused typedef or variable. The compiler should optimise
* it away entirely.
*/
#define _O_CTASSERT(x) _O__CTASSERT(x, __LINE__)
#define _O__CTASSERT(x, y) _O___CTASSERT(x, y)
#define _O___CTASSERT(x, y) while (0) { \
hselaskyUnsubmitted
Not Done
Inline Actions

Should this be enclosed with while (0) and not "do { } while (0) "?

hselasky: Should this be enclosed with while (0) and not "do { } while (0) "?
bzAuthorUnsubmitted
Done
Inline Actions

Would a while (0) { } be optimized out without ever entering the block because it can never happen?

bz: Would a while (0) { } be optimized out without ever entering the block because it can never…
hselaskyUnsubmitted
Not Done
Inline Actions

Yes, with -O2, but after parsing the code. So I believe any asserts will trigger.

hselasky: Yes, with -O2, but after parsing the code. So I believe any asserts will trigger.
typedef char __assert_line_ ## y[(x) ? 1 : -1]; \
__assert_line_ ## y _x; \
_x[0] = '\0'; \
}
#define BUILD_BUG() do { CTASSERT(0); } while (0) #define BUILD_BUG() do { CTASSERT(0); } while (0)
#define BUILD_BUG_ON(x) CTASSERT(!(x)) #define BUILD_BUG_ON(x) _O_CTASSERT(!(x))
#define BUILD_BUG_ON_MSG(x, msg) BUILD_BUG_ON(x) #define BUILD_BUG_ON_MSG(x, msg) BUILD_BUG_ON(x)
#define BUILD_BUG_ON_NOT_POWER_OF_2(x) BUILD_BUG_ON(!powerof2(x)) #define BUILD_BUG_ON_NOT_POWER_OF_2(x) BUILD_BUG_ON(!powerof2(x))
#define BUILD_BUG_ON_INVALID(expr) while (0) { (void)(expr); } #define BUILD_BUG_ON_INVALID(expr) while (0) { (void)(expr); }
extern const volatile int lkpi_build_bug_on_zero; extern const volatile int lkpi_build_bug_on_zero;
#define BUILD_BUG_ON_ZERO(x) ((x) ? lkpi_build_bug_on_zero : 0) #define BUILD_BUG_ON_ZERO(x) ((x) ? lkpi_build_bug_on_zero : 0)
#define BUG() panic("BUG at %s:%d", __FILE__, __LINE__) #define BUG() panic("BUG at %s:%d", __FILE__, __LINE__)
▲ Show 20 Lines • Show All 538 Lines • Show Last 20 Lines
View Options

sys/dev/vt/vt_core.c

Show First 20 Lines • Show All 83 Lines • ▼ Show 20 Lines
#define U8_C(x) x ## U #define U8_C(x) x ## U
#define S16_C(x) x #define S16_C(x) x
#define U16_C(x) x ## U #define U16_C(x) x ## U
#define S32_C(x) x #define S32_C(x) x
#define U32_C(x) x ## U #define U32_C(x) x ## U
#define S64_C(x) x ## LL #define S64_C(x) x ## LL
#define U64_C(x) x ## ULL #define U64_C(x) x ## ULL
/*
* BUILD_BUG_ON() can happen inside functions where _Static_assert() does not
* seem to work. Use old-schoold-ish CTASSERT from before commit
* a3085588a88fa58eb5b1eaae471999e1995a29cf but also make sure we do not
* end up with an unused typedef or variable. The compiler should optimise
* it away entirely.
*/
#define _O_CTASSERT(x) _O__CTASSERT(x, __LINE__)
#define _O__CTASSERT(x, y) _O___CTASSERT(x, y)
#define _O___CTASSERT(x, y) while (0) { \
hselaskyUnsubmitted
Not Done
Inline Actions

Should this be enclosed with while (0) and not "do { } while (0) "?

hselasky: Should this be enclosed with while (0) and not "do { } while (0) "?
bzAuthorUnsubmitted
Done
Inline Actions

Would a while (0) { } be optimized out without ever entering the block because it can never happen?

bz: Would a while (0) { } be optimized out without ever entering the block because it can never…
hselaskyUnsubmitted
Not Done
Inline Actions

Yes, with -O2, but after parsing the code. So I believe any asserts will trigger.

hselasky: Yes, with -O2, but after parsing the code. So I believe any asserts will trigger.
typedef char __assert_line_ ## y[(x) ? 1 : -1]; \
__assert_line_ ## y _x; \
_x[0] = '\0'; \
}
#define BUILD_BUG() do { CTASSERT(0); } while (0) #define BUILD_BUG() do { CTASSERT(0); } while (0)
#define BUILD_BUG_ON(x) CTASSERT(!(x)) #define BUILD_BUG_ON(x) _O_CTASSERT(!(x))
#define BUILD_BUG_ON_MSG(x, msg) BUILD_BUG_ON(x) #define BUILD_BUG_ON_MSG(x, msg) BUILD_BUG_ON(x)
#define BUILD_BUG_ON_NOT_POWER_OF_2(x) BUILD_BUG_ON(!powerof2(x)) #define BUILD_BUG_ON_NOT_POWER_OF_2(x) BUILD_BUG_ON(!powerof2(x))
#define BUILD_BUG_ON_INVALID(expr) while (0) { (void)(expr); } #define BUILD_BUG_ON_INVALID(expr) while (0) { (void)(expr); }
extern const volatile int lkpi_build_bug_on_zero; extern const volatile int lkpi_build_bug_on_zero;
#define BUILD_BUG_ON_ZERO(x) ((x) ? lkpi_build_bug_on_zero : 0) #define BUILD_BUG_ON_ZERO(x) ((x) ? lkpi_build_bug_on_zero : 0)
#define BUG() panic("BUG at %s:%d", __FILE__, __LINE__) #define BUG() panic("BUG at %s:%d", __FILE__, __LINE__)
▲ Show 20 Lines • Show All 538 Lines • Show Last 20 Lines