Page MenuHomeFreeBSD
Differential D38028

makefs: handle mtree link= for ZFS
ClosedPublic
Actions

Authored by brooks on Jan 12 2023, 12:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 15, 7:08 AM
Unknown Object (File)
Wed, Oct 15, 6:13 AM
Unknown Object (File)
Sun, Oct 12, 7:20 PM
Unknown Object (File)
Sun, Oct 12, 7:20 PM
Unknown Object (File)
Sun, Oct 12, 7:20 PM
Unknown Object (File)
Sun, Oct 12, 7:20 PM
Unknown Object (File)
Sun, Oct 12, 7:49 AM
Unknown Object (File)
Sat, Oct 11, 9:16 PM
View All Files
Subscribers
delphij
imp

Details

Reviewers
markj
Commits
rGb78d5b424145: makefs: handle mtree link= for ZFS
Summary

When a link target is specified use it rather than attempting to read
a potentially non-existant file.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 49073
Build 45962: arc lint + arc unit

Event Timeline

brooks created this revision.Jan 12 2023, 12:11 AM
Herald added subscribers: delphij, imp. · View Herald TranscriptJan 12 2023, 12:11 AM
brooks requested review of this revision.Jan 12 2023, 12:11 AM
Harbormaster completed remote builds in B49068: Diff 114984.Jan 12 2023, 12:11 AM
brooks added a parent revision: D38027: makefs: handle mtree contents= in zfs.Jan 12 2023, 12:11 AM
brooks added a child revision: D38029: makefs: don't needlessly require directories to exist.
markj accepted this revision.Jan 12 2023, 2:23 AM
markj added inline comments.
usr.sbin/makefs/zfs/fs.c
304

n is signed so this might give rise to a signed/unsigned comparison warning? Perhaps add a declaration of n to each block.

This revision is now accepted and ready to land.Jan 12 2023, 2:23 AM
brooks updated this revision to Diff 115000.Jan 12 2023, 5:47 PM
  • Avoid signed vs unsigned comparison issues
This revision now requires review to proceed.Jan 12 2023, 5:47 PM
Harbormaster completed remote builds in B49073: Diff 115000.Jan 12 2023, 5:47 PM
brooks marked an inline comment as done.Jan 12 2023, 5:50 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 12 2023, 6:21 PM
Closed by commit rGb78d5b424145: makefs: handle mtree link= for ZFS (authored by brooks). · Explain Why
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rGb78d5b424145: makefs: handle mtree link= for ZFS.

Revision Contents
Changeset List

PathSize
usr.sbin/
makefs/
zfs/
20 lines

Diff 115000

View Options

usr.sbin/makefs/zfs/fs.c

Loading...