Page MenuHomeFreeBSD
Differential D37932

linuxkpi: Add `freeram` and `freehigh` to `struct sysinfo`
ClosedPublic
Actions

Authored by dumbbell on Jan 2 2023, 9:28 PM.
Tags
None
Referenced Files
F86617688: D37932.diff
Sun, Jun 23, 2:48 AM
Unknown Object (File)
Dec 23 2023, 1:48 AM
Unknown Object (File)
Nov 4 2023, 5:17 AM
Unknown Object (File)
Nov 3 2023, 12:11 AM
Unknown Object (File)
Nov 3 2023, 12:03 AM
Unknown Object (File)
Nov 2 2023, 11:52 PM
Unknown Object (File)
Aug 5 2023, 5:22 PM
Unknown Object (File)
Aug 5 2023, 5:21 PM
View All 21 Files
Subscribers
emaste
imp
linuxkpi

Details

Reviewers
manu
bz
Commits
rG1b1901620028: linuxkpi: Add `freeram` and `freehigh` to `struct sysinfo`
rGe400b695991b: linuxkpi: Add `freeram` and `freehigh` to `struct sysinfo`
Summary

The struct layout is modified with this commit because new fields are added in the middle, keeping original Linux order.

This is part of the update of the DRM drivers to Linux 5.13.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dumbbell created this revision.Jan 2 2023, 9:28 PM
Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptJan 2 2023, 9:28 PM
dumbbell requested review of this revision.Jan 2 2023, 9:28 PM
dumbbell edited the summary of this revision. (Show Details)Jan 2 2023, 9:32 PM
emaste added inline comments.Jan 3 2023, 4:13 PM
sys/compat/linuxkpi/common/include/linux/mm.h
147–151

Spacing is odd, is this just Phabricator misrendering?

dumbbell added inline comments.Jan 25 2023, 10:31 PM
sys/compat/linuxkpi/common/include/linux/mm.h
147–151

Each line has the form:

<Tab>uint64_t totalram;<Tab>/* Comment */

So yeah, the tabs are rendered incorrectly. Should I use spaces between the field name and the comment?

emaste added inline comments.Jan 26 2023, 12:23 AM
sys/compat/linuxkpi/common/include/linux/mm.h
147–151

it's fine as long as it's consistent (with the existing file or at least with itself)

dumbbell marked 2 inline comments as done.Jan 27 2023, 8:58 PM
manu accepted this revision.Jan 28 2023, 8:50 AM
This revision is now accepted and ready to land.Jan 28 2023, 8:50 AM
Closed by commit rGe400b695991b: linuxkpi: Add `freeram` and `freehigh` to `struct sysinfo` (authored by dumbbell). · Explain WhyJan 30 2023, 10:18 PM
This revision was automatically updated to reflect the committed changes.
dumbbell added a commit: rGe400b695991b: linuxkpi: Add `freeram` and `freehigh` to `struct sysinfo`.
dumbbell added a commit: rG1b1901620028: linuxkpi: Add `freeram` and `freehigh` to `struct sysinfo`.Feb 16 2023, 12:01 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
8 lines
src/
2 lines

Diff 114718

View Options

sys/compat/linuxkpi/common/include/linux/mm.h

Loading...
View Options

sys/compat/linuxkpi/common/src/linux_page.c

Loading...