LinuxKPI: linux/seqlock.h: Fix write_seqcount_(begin|end)
ClosedPublic
Actions

Authored by wulf on Dec 14 2022, 3:24 PM.

Details

Reviewers

manu
dumbbell
• hselasky
bz

Group Reviewers

linuxkpi

Commits

rG68f08e26e279: LinuxKPI: linux/seqlock.h: Fix write_seqcount_(begin|end)

Summary

linux/seqlock.h: Fix write_seqcount_(begin|end)
in seqcount_mutex_t case with removal of extraneous mutex lock/unlock
calls and addition of missing critical section.

While here strip one inline wrap layer to reduce code size.

Fixes startup lockup of i915kms in drm-kmod v5.12

Test Plan

Build drm-kmod v5.12 and kldload i915kms after than

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

wulf created this revision.Dec 14 2022, 3:24 PM

Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptDec 14 2022, 3:24 PM

wulf requested review of this revision.Dec 14 2022, 3:24 PM

Harbormaster completed remote builds in B48716: Diff 114143.Dec 14 2022, 3:24 PM

wulf added a reviewer: linuxkpi.Dec 14 2022, 3:26 PM

wulf edited the summary of this revision. (Show Details)

Looks good to me.

This revision is now accepted and ready to land.Dec 14 2022, 3:40 PM

Seems fine from scrolling through. Thanks!

Closed by commit rG68f08e26e279: LinuxKPI: linux/seqlock.h: Fix write_seqcount_(begin|end) (authored by wulf). · Explain WhyDec 24 2022, 9:02 AM

This revision was automatically updated to reflect the committed changes.

wulf added a commit: rG68f08e26e279: LinuxKPI: linux/seqlock.h: Fix write_seqcount_(begin|end).

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

seqlock.h

94 lines

Diff 114529

View Options

sys/compat/linuxkpi/common/include/linux/seqlock.h

LinuxKPI: linux/seqlock.h: Fix write_seqcount_(begin|end)ClosedPublicActions