Page MenuHomeFreeBSD
Differential D37659

dtrace: remove unused defines
ClosedPublic
Actions

Authored by mhorne on Dec 9 2022, 6:51 PM.
Tags
None
Referenced Files
F87098762: D37659.diff
Sat, Jun 29, 8:09 AM
Unknown Object (File)
Thu, Jun 27, 6:08 PM
Unknown Object (File)
Wed, Jun 26, 10:39 PM
Unknown Object (File)
May 24 2024, 2:54 AM
Unknown Object (File)
May 12 2024, 10:28 AM
Unknown Object (File)
Dec 20 2023, 5:23 AM
Unknown Object (File)
Dec 12 2023, 4:41 PM
Unknown Object (File)
Oct 24 2023, 1:10 PM
View All 18 Files
Subscribers
andrew
emaste
imp

Details

Reviewers
markj
gnn
emaste
Group Reviewers
DTrace
Commits
rG9534ea54cfa1: dtrace: remove unused defines
rG2f2ec4bce960: dtrace: remove unused defines

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 48682
Build 45568: arc lint + arc unit

Event Timeline

mhorne created this revision.Dec 9 2022, 6:51 PM
Herald added a reviewer: gnn. · View Herald TranscriptDec 9 2022, 6:51 PM
Herald added subscribers: emaste, andrew, imp. · View Herald Transcript
mhorne requested review of this revision.Dec 9 2022, 6:51 PM
Harbormaster completed remote builds in B48682: Diff 114016.Dec 9 2022, 6:51 PM
emaste accepted this revision.Dec 9 2022, 6:54 PM
emaste added inline comments.
sys/cddl/dev/dtrace/riscv/dtrace_isa.c
55–58

Worth keeping this comment (with typo fixed) for MAX_USTACK_DEPTH?

This revision is now accepted and ready to land.Dec 9 2022, 6:54 PM
markj accepted this revision as: markj.Dec 9 2022, 7:13 PM
markj added inline comments.
sys/cddl/dev/dtrace/riscv/dtrace_isa.c
55–58

I don't have a strong feeling about it. On x86 this limit is defined as a variable instead, also without a comment.

Closed by commit rG2f2ec4bce960: dtrace: remove unused defines (authored by mhorne). · Explain WhyJan 12 2023, 3:08 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG2f2ec4bce960: dtrace: remove unused defines.
mhorne added a commit: rG9534ea54cfa1: dtrace: remove unused defines.Jan 23 2023, 4:46 PM

Revision Contents
Changeset List

PathSize
sys/
cddl/
dev/
dtrace/
aarch64/
6 lines
arm/
8 lines
riscv/
6 lines

Diff 114016

View Options

sys/cddl/dev/dtrace/aarch64/dtrace_isa.c

Loading...
View Options

sys/cddl/dev/dtrace/arm/dtrace_isa.c

Loading...
View Options

sys/cddl/dev/dtrace/riscv/dtrace_isa.c

Loading...