Page MenuHomeFreeBSD
Differential D37657

riscv: always include frame pointer
ClosedPublic
Actions

Authored by mhorne on Dec 9 2022, 6:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 10, 1:04 PM
Unknown Object (File)
May 3 2024, 5:22 AM
Unknown Object (File)
Dec 23 2023, 12:48 PM
Unknown Object (File)
Jul 4 2023, 9:32 AM
Unknown Object (File)
Jul 4 2023, 9:26 AM
Unknown Object (File)
Jul 1 2023, 5:33 PM
Unknown Object (File)
Jul 1 2023, 5:23 PM
Unknown Object (File)
Jun 16 2023, 2:53 AM
View All 20 Files
Subscribers
imp
jhb

Details

Reviewers
jhb
Group Reviewers
riscv
Commits
rG217c99d12a74: riscv: always include frame pointer
rGb926b6db37f3: riscv: always include frame pointer
Summary

Specifically it is missing in kernel modules, meaning a proper backtrace
can't be constructed.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mhorne created this revision.Dec 9 2022, 6:50 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 9 2022, 6:50 PM
mhorne requested review of this revision.Dec 9 2022, 6:50 PM
Harbormaster completed remote builds in B48680: Diff 114014.Dec 9 2022, 6:50 PM
jhb accepted this revision.Dec 9 2022, 6:54 PM
jhb added a subscriber: jhb.

I wish DTR_ENABLED was spelled as something more obvious like DTRACE_ENABLED. I had to go grep to figure out what it means.

This revision is now accepted and ready to land.Dec 9 2022, 6:54 PM
Closed by commit rGb926b6db37f3: riscv: always include frame pointer (authored by mhorne). · Explain WhyJan 12 2023, 3:08 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rGb926b6db37f3: riscv: always include frame pointer.
mhorne added a commit: rG217c99d12a74: riscv: always include frame pointer.Jan 23 2023, 4:46 PM

Revision Contents
Changeset List

PathSize
sys/
conf/
2 lines
3 lines

Diff 114992

View Options

sys/conf/Makefile.riscv

Loading...
View Options

sys/conf/kmod.mk

Loading...