Page MenuHomeFreeBSD

vmm: Free vCPUs when destroying them.
ClosedPublic

Authored by jhb on Dec 9 2022, 12:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 31, 8:01 AM
Unknown Object (File)
Mon, Jul 7, 6:44 AM
Unknown Object (File)
Sun, Jul 6, 7:10 AM
Unknown Object (File)
Sat, Jul 5, 9:41 PM
Unknown Object (File)
Sat, Jul 5, 5:57 PM
Unknown Object (File)
Sat, Jul 5, 10:27 AM
Unknown Object (File)
Jun 29 2025, 9:55 PM
Unknown Object (File)
Jun 27 2025, 1:38 AM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Dec 9 2022, 12:58 AM
This revision is now accepted and ready to land.Dec 9 2022, 7:13 AM
corvink added a subscriber: corvink.
corvink added inline comments.
sys/amd64/vmm/vmm.c
670

Should we set vm->vcpu[i] to NULL after calling vcpu_cleanup to avoid any use-after-free?

sys/amd64/vmm/vmm.c
670

We are about to free(vm) in the caller after this function returns in the destroy case, so use-after-free isn't really possible I think.

This revision was automatically updated to reflect the committed changes.