Page MenuHomeFreeBSD
Differential D37318

dummynet: fix codel
ClosedPublic
Actions

Authored by kp on Nov 9 2022, 5:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 18, 12:12 AM
Unknown Object (File)
Mon, May 18, 12:09 AM
Unknown Object (File)
Sun, May 17, 11:41 PM
Unknown Object (File)
Tue, Apr 28, 8:56 PM
Unknown Object (File)
Mon, Apr 27, 11:33 AM
Unknown Object (File)
Apr 11 2026, 7:27 PM
Unknown Object (File)
Mar 26 2026, 7:43 PM
Unknown Object (File)
Mar 24 2026, 2:30 PM
View All Files
Subscribers
ae
donner
glebius
imp
melifaro

Details

Reviewers
None
Group Reviewers
network
pfsense
Commits
rG26b9e1f07fa5: dummynet: fix codel
Summary

Serialize rcvif when enqueing packets for codel. We already tried to
restore the serialized rcvif in fq_codel_extract_head(), but that
doesn't work when we fail to serialize it first, so we ended up dropping
all packets passed through codel.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp created this revision.Nov 9 2022, 5:28 PM
Herald added subscribers: glebius, donner, melifaro and 2 others. · View Herald TranscriptNov 9 2022, 5:28 PM
Harbormaster completed remote builds in B48246: Diff 112814.Nov 9 2022, 5:28 PM
kp requested review of this revision.Nov 9 2022, 5:28 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 11 2022, 12:19 PM
Closed by commit rG26b9e1f07fa5: dummynet: fix codel (authored by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.
kp added a commit: rG26b9e1f07fa5: dummynet: fix codel.

Revision Contents
Changeset List

PathSize
sys/
netpfil/
ipfw/
3 lines

Diff 112926

View Options

sys/netpfil/ipfw/dn_sched_fq_codel.c

Loading...