While there, add a missing word nearby.
Details
- Reviewers
carlavilla gjb riggs - Group Reviewers
docs ports secteam Ports Committers
make all
Eyeball lynx output
Diff Detail
- Repository
- R9 FreeBSD doc repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 50161 Build 47053: arc lint + arc unit
Event Timeline
Side note: in a different chapter (out of scope for this review) there is, again, misuse of the phrase Security Officer Team.
https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-maintainer
documentation/content/en/books/porters-handbook/security/_index.adoc | ||
---|---|---|
101–102 | The order of words is strange (for example, as early after a security vulnerability is discovered as possible). Also, re: discovery, port users should be notified only if a vulnerability is already publicly disclosed. | |
108–109 | Security Officer is not a team. Also, conciseness. | |
110–111 | Security Officer is not a team. | |
111 | Do you mean, a bug report with a summary line something like what's below?
| |
111–113 | Security Officer is not a team. |
If a bug report involves a publicly-disclosed vulnerability for which there's not yet a VuXML entry, then the report should have:
- ports-secteam@ amongst CC recipients
- keyword security
- flag merge-quarterly set to ?
- priority maximised, to Normal
- severity maximised, to Affects Many People.
Also: why do we encourage addressing the Security Team, or Security Officer, without mentioning the (more relevant) Ports Security Team?
Good questions all. Waiting for a ports secteam member to address them so I can revise this usefully.
documentation/content/en/books/porters-handbook/security/_index.adoc | ||
---|---|---|
108–109 | Generally, here and all the other places in the doc: I'd mention both the Security Team (#t-secteam) and Ports Security Team(#t-ports-secteam). Our vuxml page (https://vuxml.freebsd.org/freebsd/index.html) contains both base system and ports vulnerabilities. |
Updated patch to follow after it finishes building and I look it over.
documentation/content/en/books/porters-handbook/security/_index.adoc | ||
---|---|---|
101–102 | Agreed to both, but out of scope. | |
108–109 | Do you mean mention both where either is mentioned? Otherwise there's only here, unless I missed something. | |
111 | Yes. |