Page MenuHomeFreeBSD
Differential D37005

tzsetup: symlink /etc/localtime instead of copying
ClosedPublic
Actions

Authored by emaste on Oct 14 2022, 3:14 PM.
Tags
None
Referenced Files
F154411616: D37005.id130491.diff
Tue, Apr 28, 9:49 AM
F154321507: D37005.id.diff
Mon, Apr 27, 8:10 PM
Unknown Object (File)
Sat, Apr 18, 2:15 PM
Unknown Object (File)
Sat, Apr 18, 5:24 AM
Unknown Object (File)
Thu, Apr 16, 10:58 PM
Unknown Object (File)
Wed, Apr 15, 12:40 AM
Unknown Object (File)
Tue, Apr 7, 9:36 PM
Unknown Object (File)
Sun, Apr 5, 4:56 PM
View All Files
Subscribers
imp
jrm
philip

Details

Reviewers
bapt
kevans
philip
Commits
rGfc43a1b6842a: tzsetup: symlink /etc/localtime instead of copying
rG5e16809c953f: tzsetup: symlink /etc/localtime instead of copying
Summary

Ref twitter thread at https://twitter.com/kaevans91/status/1580652408861958144

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.Oct 14 2022, 3:14 PM
emaste created this revision.
emaste mentioned this in D37004: tzsetup: allow choice of copy or symlink for /etc/localtime.
bapt accepted this revision.Oct 14 2022, 4:00 PM
This revision is now accepted and ready to land.Oct 14 2022, 4:00 PM
kevans accepted this revision.Oct 14 2022, 6:13 PM
philip accepted this revision.Oct 16 2022, 2:55 AM
philip added a subscriber: philip.

Looks good to me. Thank you!

jrm added a subscriber: jrm.Nov 23 2023, 6:55 PM

A key argument for this change is that we align with what most Linux distributions are doing. Since Linux/systemd says it should be a symbolic link, some third-party software like Chromium or R runs into problems when the zoneinfo file is copied to /etc/. The arguments I've read against this change (https://twitter.com/kaevans91/status/1580652408861958144) describe (theoretical) problems when /usr isn't mounted. However, peter@ says,

"I’ve never found a case where a symlink doesn’t Just Work."

jrm mentioned this in D42738: tzsetup: default to symlink.Nov 23 2023, 7:26 PM
philip added a comment.Nov 24 2023, 1:13 AM

I don't see any reason not to do this. @emaste: do you want to commit this, or shall I?

emaste added a comment.Nov 24 2023, 1:25 AM

I'll push it later today or tomorrow

Closed by commit rG5e16809c953f: tzsetup: symlink /etc/localtime instead of copying (authored by emaste). · Explain WhyNov 24 2023, 2:17 AM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rG5e16809c953f: tzsetup: symlink /etc/localtime instead of copying.
Herald added a subscriber: imp. · View Herald TranscriptNov 24 2023, 2:17 AM
emaste added a commit: rGfc43a1b6842a: tzsetup: symlink /etc/localtime instead of copying.Aug 1 2024, 3:38 PM
emaste added a reverting change: rG06a6d0259fe5: Revert "tzsetup: symlink /etc/localtime instead of copying".Sep 21 2024, 11:11 AM
olce mentioned this in D46725: tzsetup: correct timezone symlink target.Sep 30 2024, 3:35 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
tzsetup/
2 lines
119 lines

Diff 130491

View Options

usr.sbin/tzsetup/tzsetup.8

Loading...
View Options

usr.sbin/tzsetup/tzsetup.c

Loading...