Page MenuHomeFreeBSD

vmm: validate icr value
ClosedPublic

Authored by corvink on Oct 12 2022, 12:30 PM.
Tags
Referenced Files
Unknown Object (File)
Wed, Dec 4, 11:06 PM
Unknown Object (File)
Nov 17 2024, 1:05 PM
Unknown Object (File)
Sep 29 2024, 6:28 PM
Unknown Object (File)
Sep 29 2024, 6:27 PM
Unknown Object (File)
Sep 29 2024, 4:35 PM
Unknown Object (File)
Sep 24 2024, 8:04 PM
Unknown Object (File)
Sep 23 2024, 11:55 PM
Unknown Object (File)
Sep 20 2024, 9:25 PM

Details

Summary

Not all combinations of icr values are allowed. Neither Intel nor AMD
document what happens when an invalid value is written to the icr.
Ignore the IPI. So, the guest will note that the IPI wasn't delivered.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/amd64/vmm/io/vlapic.c
992

We may want to explicitly comment here that level-deassert INIT is being purposefully ignored because it is a defined thing (so "valid" in one sense), but also something we should ignore.

This revision is now accepted and ready to land.Oct 13 2022, 4:41 PM
  • check for level deassert INIT and comment why we handle it as invalid
This revision now requires review to proceed.Oct 14 2022, 6:54 AM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 14 2022, 10:04 AM
Closed by commit rG2a2a64c4b93f: vmm: validate icr value (authored by corvink, committed by manu). · Explain Why
This revision was automatically updated to reflect the committed changes.