Page MenuHomeFreeBSD
Differential D36946

vmm: validate icr value
ClosedPublic
Actions

Authored by corvink on Oct 12 2022, 12:30 PM.
Tags
Referenced Files
Unknown Object (File)
Sat, Jun 1, 10:26 PM
Unknown Object (File)
May 20 2024, 10:02 PM
Unknown Object (File)
May 14 2024, 1:48 PM
Unknown Object (File)
May 11 2024, 12:34 PM
Unknown Object (File)
May 11 2024, 6:57 AM
Unknown Object (File)
May 11 2024, 6:56 AM
Unknown Object (File)
May 11 2024, 1:27 AM
Unknown Object (File)
Dec 23 2023, 1:02 AM
View All 30 Files
Subscribers
bcran
evgueni.gavrilov_itglobal.com
imp
rgrimes

Details

Reviewers
jhb
markj
manu
Group Reviewers
bhyve
Commits
rG168726513cdf: vmm: validate icr value
rG2a2a64c4b93f: vmm: validate icr value
Summary

Not all combinations of icr values are allowed. Neither Intel nor AMD
document what happens when an invalid value is written to the icr.
Ignore the IPI. So, the guest will note that the IPI wasn't delivered.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

corvink created this revision.Oct 12 2022, 12:30 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptOct 12 2022, 12:30 PM
corvink requested review of this revision.Oct 12 2022, 12:30 PM
corvink mentioned this in D35623: vmm: permit some IPIs to be handled by userspace.Oct 12 2022, 12:34 PM
jhb added inline comments.Oct 13 2022, 4:41 PM
sys/amd64/vmm/io/vlapic.c
992

We may want to explicitly comment here that level-deassert INIT is being purposefully ignored because it is a defined thing (so "valid" in one sense), but also something we should ignore.

jhb accepted this revision.Oct 13 2022, 4:41 PM
This revision is now accepted and ready to land.Oct 13 2022, 4:41 PM
corvink updated this revision to Diff 111781.Oct 14 2022, 6:54 AM
  • check for level deassert INIT and comment why we handle it as invalid
This revision now requires review to proceed.Oct 14 2022, 6:54 AM
evgueni.gavrilov_itglobal.com added a subscriber: evgueni.gavrilov_itglobal.com.Oct 14 2022, 7:18 AM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 14 2022, 10:04 AM
Closed by commit rG2a2a64c4b93f: vmm: validate icr value (authored by corvink, committed by manu). · Explain Why
This revision was automatically updated to reflect the committed changes.
manu added a commit: rG2a2a64c4b93f: vmm: validate icr value.
corvink added a commit: rG168726513cdf: vmm: validate icr value.Dec 22 2022, 9:23 AM

Revision Contents
Changeset List

PathSize
sys/
amd64/
vmm/
io/
91 lines

Diff 111805

View Options

sys/amd64/vmm/io/vlapic.c

Loading...