Clear the indirect flag in the GICv3 ITS driver
ClosedPublic
Actions

Authored by andrew on Oct 4 2022, 11:51 AM.

Details

Reviewers

imp
manu

Group Reviewers

arm64

Commits

rG39c064581757: Clear the indirect flag in the GICv3 ITS driver
rGa0a4f5cf1723: Clear the indirect flag in the GICv3 ITS driver

Summary

The indirect flag tells the hardware to use a flat or two level table.
As we only support using the flat table ensure the flag that marks
which is in use is set correctly.

We can't rely on this being set correctly as some firmware may set the
indirect flag, e.g. booting from LinuxBoot.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Oct 4 2022, 11:51 AM

Herald added a reviewer: manu. · View Herald TranscriptOct 4 2022, 11:51 AM

Herald added a subscriber: emaste. · View Herald Transcript

andrew requested review of this revision.Oct 4 2022, 11:51 AM

Harbormaster completed remote builds in B47687: Diff 111415.Oct 4 2022, 11:51 AM

This fixes the issues I was seeing with missing interrupts...
I get to mountroot> now on the images that before would stall

This revision is now accepted and ready to land.Oct 4 2022, 3:28 PM

Closed by commit rGa0a4f5cf1723: Clear the indirect flag in the GICv3 ITS driver (authored by andrew). · Explain WhyOct 4 2022, 4:15 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rGa0a4f5cf1723: Clear the indirect flag in the GICv3 ITS driver.

andrew added a commit: rG39c064581757: Clear the indirect flag in the GICv3 ITS driver.Jan 23 2023, 12:37 PM

Revision Contents
Changeset List

Path

Size

sys/

arm64/

gic_v3_reg.h

3 lines

gicv3_its.c

2 lines

Diff 111434

View Options

sys/arm64/arm64/gic_v3_reg.h