Page MenuHomeFreeBSD
Differential D36598

ure(4): Fix computation of L4 payload offset for IPv4 and IPv6.
Needs ReviewPublic
Actions

Authored by • hselasky on Sep 16 2022, 2:07 PM.
Tags
None
Referenced Files
F172610650: D36598.diff
Sat, Sep 19, 4:32 PM
Unknown Object (File)
Sun, Sep 6, 4:56 PM
Unknown Object (File)
Fri, Sep 4, 8:44 PM
Unknown Object (File)
Fri, Aug 21, 7:09 AM
Unknown Object (File)
Aug 15 2026, 4:15 AM
Unknown Object (File)
Aug 13 2026, 8:50 PM
Unknown Object (File)
Aug 13 2026, 4:09 PM
Unknown Object (File)
Aug 11 2026, 6:08 PM
View All Files
Subscribers
afedorov
imp
zlei

Details

Reviewers
kevlo
mav

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

• hselasky created this revision.Sep 16 2022, 2:07 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 16 2022, 2:07 PM
• hselasky requested review of this revision.Sep 16 2022, 2:07 PM
• hselasky updated this revision to Diff 110634.Sep 16 2022, 2:10 PM

Check next protocol field for IPv6.

mav added inline comments.Sep 16 2022, 3:53 PM
sys/dev/usb/net/if_ure.c
2217

I see that tcp_default_output() and other transmission places are setting csum_data to the offset of the checksum field in respective protocol. In that sense the old code makes sense, checking how far into the packet the checksum field resides.

zlei added a subscriber: zlei.Nov 25 2022, 2:50 PM
afedorov added a subscriber: afedorov.Nov 26 2022, 7:41 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
usb/
net/
23 lines

Diff 110634

View Options

sys/dev/usb/net/if_ure.c

Loading...