riscv: add an assert to pmap_remove_pages()
ClosedPublic
Actions

Authored by mhorne on Sep 14 2022, 2:59 PM.

Tags

None

Referenced Files

	F166290880: D36564.id111525.diff
	Wed, Aug 12, 5:11 PM

	F166117103: D36564.id.diff
	Tue, Aug 11, 8:55 PM

	Unknown Object (File)
	Mon, Aug 10, 6:43 AM

	Unknown Object (File)
	Sun, Aug 9, 3:49 PM

	Unknown Object (File)
	Sat, Aug 8, 2:26 AM

	Unknown Object (File)
	Fri, Aug 7, 4:46 PM

	Unknown Object (File)
	Sat, Jul 25, 11:11 PM

	Unknown Object (File)
	Wed, Jul 22, 4:39 PM

View All Files

Subscribers

imp

Details

Reviewers

markj

Group Reviewers

riscv

Commits

rGcffe8054a61c: riscv: add an assert to pmap_remove_pages()
rG99fe523778af: riscv: add an assert to pmap_remove_pages()

Summary

Similar checks exist for both arm64 and amd64, but note that for amd64
it is a bare panic().

This would more clearly report the problem described in D36563/PR 266108.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.Sep 14 2022, 2:59 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 14 2022, 2:59 PM

mhorne requested review of this revision.Sep 14 2022, 2:59 PM

Harbormaster completed remote builds in B47379: Diff 110548.Sep 14 2022, 2:59 PM

mhorne edited the summary of this revision. (Show Details)Sep 14 2022, 3:00 PM

markj accepted this revision.Sep 15 2022, 10:16 AM

This revision is now accepted and ready to land.Sep 15 2022, 10:16 AM

Closed by commit rG99fe523778af: riscv: add an assert to pmap_remove_pages() (authored by mhorne). · Explain WhyOct 6 2022, 10:07 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rG99fe523778af: riscv: add an assert to pmap_remove_pages().

mhorne added a commit: rGcffe8054a61c: riscv: add an assert to pmap_remove_pages().Oct 13 2022, 2:10 PM

Revision Contents
Changeset List

Path

Size

sys/

riscv/

pmap.c

4 lines

Diff 111525

View Options

riscv: add an assert to pmap_remove_pages()ClosedPublicActions