Page MenuHomeFreeBSD
Differential D36503

arm64: Read tpidrro_el0 for the 32-bit TLS pointer.
AbandonedPublic
Actions

Authored by jhb on Sep 9 2022, 9:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 14, 5:41 PM
Unknown Object (File)
Mon, Sep 14, 5:29 PM
Unknown Object (File)
Sat, Sep 12, 12:05 PM
Unknown Object (File)
Thu, Sep 10, 5:30 AM
Unknown Object (File)
Tue, Sep 8, 4:20 AM
Unknown Object (File)
Tue, Sep 8, 1:45 AM
Unknown Object (File)
Sat, Sep 5, 8:13 PM
Unknown Object (File)
Sat, Sep 5, 4:58 PM
View All Files
Subscribers
emaste

Details

Reviewers
jrtc27
andrew
imp
manu
Summary

This shouldn't be a functional change since cpu_set_user_tls sets both
registers, but this is technically more correct.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 47301
Build 44188: arc lint + arc unit

Event Timeline

jhb created this revision.Sep 9 2022, 9:25 AM
Herald added a reviewer: manu. · View Herald TranscriptSep 9 2022, 9:25 AM
Herald added a subscriber: emaste. · View Herald Transcript
jhb requested review of this revision.Sep 9 2022, 9:25 AM
jhb added a parent revision: D36502: arm64: Simplify initialization of pc_freemask..
jhb added a child revision: D36504: arm,arm64: Save TLS register in mcontext_t..
Harbormaster completed remote builds in B47301: Diff 110377.Sep 9 2022, 9:26 AM
jhb mentioned this in D36504: arm,arm64: Save TLS register in mcontext_t..Sep 29 2022, 10:02 PM
jhb abandoned this revision.Sep 21 2024, 4:21 PM

Actually, I think the current code is more correct as the 32-bit kernel always uses TPIDRURW as the source of truth for TLS including for its get_arm_tls function.

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
2 lines

Diff 110377

View Options

sys/arm64/arm64/ptrace_machdep.c

Loading...