Page MenuHomeFreeBSD
Differential D36472

framework: make pkgconfig a Feature
Changes PlannedPublic
Actions

Authored by tcberner on Sep 6 2022, 8:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 23, 6:40 PM
Unknown Object (File)
Nov 28 2024, 12:02 PM
Unknown Object (File)
Nov 17 2024, 12:20 PM
Unknown Object (File)
Nov 17 2024, 6:27 AM
Unknown Object (File)
Oct 21 2024, 1:21 PM
Unknown Object (File)
Oct 18 2024, 9:36 PM
Unknown Object (File)
Oct 18 2024, 7:11 PM
Unknown Object (File)
Oct 11 2024, 7:11 AM
View All 42 Files
Subscribers
dab
emaste
rene

Details

Reviewers
bapt
mat
rene
Group Reviewers
portmgr
Summary

pkgconfig is the defacto standard to find components. Instead of
opting-in to depending on pkgconfig via USES=pkgconfig, this switches
the behaviour to be opt-out.

If a port does not want pkgconfig, it now needs to define
WITHOUT_PKGCONFIG=yes

Test Plan

Exp-run: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266266

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 47267
Build 44154: arc lint + arc unit

Event Timeline

tcberner created this revision.Sep 6 2022, 8:30 PM
Herald added 1 blocking reviewer(s): portmgr. · View Herald TranscriptSep 6 2022, 8:30 PM
Herald added subscribers: dab, emaste. · View Herald Transcript
tcberner requested review of this revision.Sep 6 2022, 8:30 PM
Harbormaster completed remote builds in B47267: Diff 110231.Sep 6 2022, 8:30 PM
tcberner added inline comments.Sep 6 2022, 8:33 PM
Mk/Features/pkgconfig.mk
10

^ check probably should be on !empty()?

tcberner updated this revision to Diff 110254.Sep 7 2022, 8:50 AM
  • remove the pkgconfig removal from the other ports to make it easier to look at
Harbormaster completed remote builds in B47277: Diff 110254.Sep 7 2022, 8:50 AM
rene accepted this revision.Sep 7 2022, 9:30 AM
rene added a subscriber: rene.
rene added inline comments.
Mk/Uses/qt-dist.mk
156

Why was qmake excluded, for efficiency?

This revision is now accepted and ready to land.Sep 7 2022, 9:30 AM
tcberner added inline comments.Sep 7 2022, 9:36 AM
Mk/Uses/qt-dist.mk
156

I think that information is lot to time :) -- I have no clue why it was done that way (if there was a good reason, the exp-run should hopefully show it).

tcberner edited the test plan for this revision. (Show Details)Sep 7 2022, 9:57 AM
tcberner planned changes to this revision.Sep 9 2022, 12:03 PM

As discussed with @bapt, I'll try to look into an other way to make pc-support better.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 111023153c88e2Sep 6 2022, 8:30 PM
Diff 2110254fc65439- remove the pkgconfig removal from the other ports to make it easier to look atSep 7 2022, 8:50 AM
This very large diff affects more than 2,000 files. Use the Changeset List to browse changes.