framework: make pkgconfig a Feature
Changes PlannedPublic
Actions

Authored by tcberner on Sep 6 2022, 8:30 PM.

Details

Reviewers

bapt
mat
rene

Group Reviewers

portmgr

Summary

pkgconfig is the defacto standard to find components. Instead of
opting-in to depending on pkgconfig via USES=pkgconfig, this switches
the behaviour to be opt-out.

If a port does not want pkgconfig, it now needs to define
WITHOUT_PKGCONFIG=yes

Test Plan

Exp-run: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266266

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 47277
Build 44164: arc lint + arc unit

Event Timeline

tcberner created this revision.Sep 6 2022, 8:30 PM

Herald added 1 blocking reviewer(s): portmgr. · View Herald TranscriptSep 6 2022, 8:30 PM

Herald added subscribers: dab, emaste. · View Herald Transcript

tcberner requested review of this revision.Sep 6 2022, 8:30 PM

Harbormaster completed remote builds in B47267: Diff 110231.Sep 6 2022, 8:30 PM

tcberner added inline comments.Sep 6 2022, 8:33 PM

Mk/Features/pkgconfig.mk
11	^ check probably should be on `!empty()`?

remove the pkgconfig removal from the other ports to make it easier to look at

Harbormaster completed remote builds in B47277: Diff 110254.Sep 7 2022, 8:50 AM

rene accepted this revision.Sep 7 2022, 9:30 AM

rene added a subscriber: rene.

rene added inline comments.

Mk/Uses/qt-dist.mk
156	Why was qmake excluded, for efficiency?

This revision is now accepted and ready to land.Sep 7 2022, 9:30 AM

tcberner added inline comments.Sep 7 2022, 9:36 AM

Mk/Uses/qt-dist.mk
156	I think that information is lot to time :) -- I have no clue why it was done that way (if there was a good reason, the exp-run should hopefully show it).